fix(planning): remove Step N prefix from AddChecklist items#547
Merged
zbigniewsobiecki merged 1 commit intodevfrom Feb 25, 2026
Merged
Conversation
Collaborator
|
✨ On it — checking the PR for that step N prefix fix |
nhopeatall
approved these changes
Feb 25, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — clean, well-scoped prompt-only change. Instructions are placed at the right locations (near AddChecklist call sites + Rules section for reinforcement), consistent across both templates, and adequately tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
planning.etathatAddChecklistitems should use clean task names (e.g., "Add helper function" instead of "Step 1: Add helper function")respond-to-planning-comment.etafor checklist items added during plan updatesChanges
src/agents/prompts/templates/planning.eta: Added two explicit instructions — one in the IMPORTANT section beforeAddChecklistcall, and one in the Rules section — instructing the LLM to omit "Step N:" prefixes from checklist itemssrc/agents/prompts/templates/respond-to-planning-comment.eta: Added a note in the "Updating the Plan and Checklists" section about using clean task names without "Step N:" prefixestests/unit/agents/prompts.test.ts: Added two tests verifying the no-prefix instructions exist in both prompt templatesTest plan
npm test— all 3228 tests pass (zero failures)npm run typecheck— zero type errorsnpm run lint— only pre-existing warning (unrelated to this change)Notes
This is a prompt-only change. The LLM (planning agent) will follow these instructions in the vast majority of cases — some rare non-compliance is acceptable and noted in the card's Risks section.
Card: https://trello.com/c/699ecb2972f1ed31177ade37
🤖 Generated with Claude Code