Skip to content

fix(triggers): skip READY TO PROCESS label for cards in non-eligible lists#555

Merged
zbigniewsobiecki merged 1 commit intodevfrom
fix/ready-to-process-unrecognized-list
Feb 25, 2026
Merged

fix(triggers): skip READY TO PROCESS label for cards in non-eligible lists#555
zbigniewsobiecki merged 1 commit intodevfrom
fix/ready-to-process-unrecognized-list

Conversation

@zbigniewsobiecki
Copy link
Copy Markdown
Member

Summary

  • Bug: When the READY TO PROCESS label was added to a card in an unrecognised list (IN PROGRESS, IN REVIEW, DONE, etc.) the handler fell through to a hardcoded 'splitting' default, firing an unintended splitting run on a card that was already in progress.
  • Fix: Replace the else fallback with an early return null so the trigger is silently skipped for any list that isn't splitting / planning / todo.
  • Log level: Downgraded from warn (misleading — it was advertising the wrong behaviour) to info.

Root cause

src/triggers/trello/label-added.ts lines 64–68 (before fix):

} else {
    // Default to splitting if list not recognized
    logger.warn('Card in unrecognized list, defaulting to splitting', { currentListId, lists });
    agentType = 'splitting';
}

Test plan

  • Updated unit test returns null when card is in an unrecognized list (e.g. IN PROGRESS) — was previously asserting agentType === 'splitting', now asserts result === null
  • All existing handle-path tests still pass (splitting / planning / todo / missing card ID)
  • npm test — 3 259 tests, 189 files, all green
  • npm run lint — no issues
  • npm run typecheck — no issues

🤖 Generated with Claude Code

…lists

When a card in IN PROGRESS, IN REVIEW, DONE or any other non-trigger list
received the READY TO PROCESS label, the handler fell through to a hardcoded
default of 'splitting', firing an unintended splitting run.

Replace the fallback with an early null return so the trigger is silently
skipped for any list that isn't splitting/planning/todo. Update the unit test
to assert null instead of the previous incorrect expectation.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@zbigniewsobiecki zbigniewsobiecki merged commit df35a3e into dev Feb 25, 2026
6 checks passed
@zbigniewsobiecki zbigniewsobiecki deleted the fix/ready-to-process-unrecognized-list branch March 16, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant