fix(triggers): skip READY TO PROCESS label for cards in non-eligible lists#555
Merged
zbigniewsobiecki merged 1 commit intodevfrom Feb 25, 2026
Merged
Conversation
…lists When a card in IN PROGRESS, IN REVIEW, DONE or any other non-trigger list received the READY TO PROCESS label, the handler fell through to a hardcoded default of 'splitting', firing an unintended splitting run. Replace the fallback with an early null return so the trigger is silently skipped for any list that isn't splitting/planning/todo. Update the unit test to assert null instead of the previous incorrect expectation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'splitting'default, firing an unintended splitting run on a card that was already in progress.elsefallback with an earlyreturn nullso the trigger is silently skipped for any list that isn'tsplitting/planning/todo.warn(misleading — it was advertising the wrong behaviour) toinfo.Root cause
src/triggers/trello/label-added.tslines 64–68 (before fix):Test plan
returns null when card is in an unrecognized list (e.g. IN PROGRESS)— was previously assertingagentType === 'splitting', now assertsresult === nullnpm test— 3 259 tests, 189 files, all greennpm run lint— no issuesnpm run typecheck— no issues🤖 Generated with Claude Code