fix(agents): address inline task prompts code review findings#595
Merged
zbigniewsobiecki merged 2 commits intodevfrom Mar 1, 2026
Merged
fix(agents): address inline task prompts code review findings#595zbigniewsobiecki merged 2 commits intodevfrom
zbigniewsobiecki merged 2 commits intodevfrom
Conversation
Phase 1 - Critical Backend Fixes: - Add missing AgentInput fields (triggerCommentBody, triggerCommentPath) for PR comment triggers - Create unified buildTaskPromptContext() in prompts/index.ts with consistent null handling - Fix modelResolution.ts to use renderInlineTaskPrompt() instead of renderCustomPrompt() - Add schema validation requiring prompts.taskPrompt (PromptsSchema no longer optional) - Add early Eta syntax validation in profile builder to catch errors at build time Phase 2 - Dashboard Fixes: - Fix save logic to always send both prompts (prevents losing inactive section) - Fix reset button: rename to "Reset All Prompts" and add confirmation dialog - Show variable descriptions in ReferencePanel - Add loading/error states in PromptsPanel - Refactor PromptsPanel to reduce cognitive complexity (extract helper components) Phase 3 - Consistency Cleanup: - Standardize YAML taskPrompt format to pipe style (debug, planning, splitting, implementation) - Remove unnecessary dbPartials size check in getSystemPrompt() and renderInlineTaskPrompt() - Add placeholder text for system prompt textarea Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…YAML) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses all critical, high, and moderate issues identified in the inline task prompts implementation code review.
Phase 1 - Critical Backend Fixes
AgentInputfields (triggerCommentBody,triggerCommentPath) for PR comment triggersbuildTaskPromptContext()inprompts/index.tswith consistent null handlingmodelResolution.tsto userenderInlineTaskPrompt()instead ofrenderCustomPrompt()prompts.taskPrompt(PromptsSchema no longer optional)Phase 2 - Dashboard Fixes
Phase 3 - Consistency Cleanup
getSystemPrompt()andrenderInlineTaskPrompt()Test plan
npm run typecheck- verify type safety improvementsnpm test- verify no regressions (all 3621 tests pass)npm run lint- verify no lint warnings🤖 Generated with Claude Code