refactor: remove postConfigure hook and make sequential gadget execution unconditional#608
Merged
zbigniewsobiecki merged 1 commit intodevfrom Mar 2, 2026
Merged
Conversation
…ion unconditional
Collaborator
|
✨ On it — checking the PR changes now |
nhopeatall
approved these changes
Mar 2, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Clean removal of a single-use abstraction. The postConfigure hook had exactly one implementation (sequentialGadgetExecution) used by one agent. Making sequential execution unconditional in createConfiguredBuilder() eliminates the registry, YAML field, schema field, IIFE resolution in the llmist backend, and the frontend dropdown — all without losing functionality. The behavioral change (all agents now get sequential gadget execution, not just implementation) is intentional per the PR description and all CI checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postConfigurehook mechanism entirely (YAML field, schema field, registry, resolution logic, builder factory option, and frontend UI dropdown)withGadgetExecutionMode('sequential')is now always called increateConfiguredBuilder()for all agentsChanges
src/agents/shared/builderFactory.ts: RemovepostConfigurefromCreateBuilderOptionsinterface, remove conditional hook call, add unconditional.withGadgetExecutionMode('sequential')src/backends/llmist/index.ts: RemovePOST_CONFIGURE_REGISTRYconstant,resolveAgentDefinitionimport, and postConfigure IIFE from builder optionssrc/agents/definitions/schema.ts: RemovepostConfigurefield fromBackendSchemasrc/agents/definitions/implementation.yaml: RemovepostConfigure: sequentialGadgetExecutionweb/src/components/settings/agent-definition-editor.tsx: Remove Post-Configure Hook dropdown and unused Select importstests/unit/agents/definitions/schema.test.ts: Remove two postConfigure-specific tests, update optional fields testtests/unit/agents/definitions/loader.test.ts: Remove postConfigure spot-check teststests/unit/agents/shared/builderFactory.test.ts: AddwithGadgetExecutionModemock, replace postConfigure tests with sequential execution testTest plan
Card: https://trello.com/c/69a5aed609d2220335221dcb
Generated with Claude Code