Skip to content

refactor: remove postConfigure hook and make sequential gadget execution unconditional#608

Merged
zbigniewsobiecki merged 1 commit intodevfrom
feature/remove-post-configure-hook
Mar 2, 2026
Merged

refactor: remove postConfigure hook and make sequential gadget execution unconditional#608
zbigniewsobiecki merged 1 commit intodevfrom
feature/remove-post-configure-hook

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Mar 2, 2026

Summary

  • Remove the postConfigure hook mechanism entirely (YAML field, schema field, registry, resolution logic, builder factory option, and frontend UI dropdown)
  • Make sequential gadget execution unconditional: withGadgetExecutionMode('sequential') is now always called in createConfiguredBuilder() for all agents
  • Update all related tests to reflect the new behavior

Changes

  • src/agents/shared/builderFactory.ts: Remove postConfigure from CreateBuilderOptions interface, remove conditional hook call, add unconditional .withGadgetExecutionMode('sequential')
  • src/backends/llmist/index.ts: Remove POST_CONFIGURE_REGISTRY constant, resolveAgentDefinition import, and postConfigure IIFE from builder options
  • src/agents/definitions/schema.ts: Remove postConfigure field from BackendSchema
  • src/agents/definitions/implementation.yaml: Remove postConfigure: sequentialGadgetExecution
  • web/src/components/settings/agent-definition-editor.tsx: Remove Post-Configure Hook dropdown and unused Select imports
  • tests/unit/agents/definitions/schema.test.ts: Remove two postConfigure-specific tests, update optional fields test
  • tests/unit/agents/definitions/loader.test.ts: Remove postConfigure spot-check tests
  • tests/unit/agents/shared/builderFactory.test.ts: Add withGadgetExecutionMode mock, replace postConfigure tests with sequential execution test

Test plan

  • All unit tests pass (463 tests)
  • TypeScript type check passes
  • Biome lint passes with no issues

Card: https://trello.com/c/69a5aed609d2220335221dcb

Generated with Claude Code

@nhopeatall
Copy link
Copy Markdown
Collaborator

✨ On it — checking the PR changes now

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Clean removal of a single-use abstraction. The postConfigure hook had exactly one implementation (sequentialGadgetExecution) used by one agent. Making sequential execution unconditional in createConfiguredBuilder() eliminates the registry, YAML field, schema field, IIFE resolution in the llmist backend, and the frontend dropdown — all without losing functionality. The behavioral change (all agents now get sequential gadget execution, not just implementation) is intentional per the PR description and all CI checks pass.

@zbigniewsobiecki zbigniewsobiecki merged commit 39256f3 into dev Mar 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants