fix(router): make acknowledgment messages role-aware per agent type#616
Merged
zbigniewsobiecki merged 1 commit intodevfrom Mar 6, 2026
Merged
fix(router): make acknowledgment messages role-aware per agent type#616zbigniewsobiecki merged 1 commit intodevfrom
zbigniewsobiecki merged 1 commit intodevfrom
Conversation
Update ACK_SYSTEM_PROMPT with role-categorized example phrases (implementation, planning, review, splitting, debug, feedback) and add an explicit role-matching instruction to the user prompt so the LLM generates language appropriate to each agent's action rather than defaulting to investigation/review phrasing for all agents. Closes https://trello.com/c/rUBjpU61 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
🤖 On it — checking the ack messages for PR 616 |
nhopeatall
approved these changes
Mar 6, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Clean, well-scoped fix to a real problem (all ack messages sounding like review-agent messages). The system prompt now covers all agent role categories, and the user prompt reinforcement ensures the LLM gets a clear signal about which role it's generating for. Tests cover the important assertion points. No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACK_SYSTEM_PROMPTinsrc/router/ackMessageGenerator.tsonly contained investigation/review-oriented example phrases ("checking", "looking into", "dig into"), biasing ALL agent acknowledgment messages toward review language regardless of which agent was triggered.Card: https://trello.com/c/rUBjpU61
Test plan
🤖 Generated with Claude Code