Skip to content

fix(router): make acknowledgment messages role-aware per agent type#616

Merged
zbigniewsobiecki merged 1 commit intodevfrom
fix/role-aware-ack-messages
Mar 6, 2026
Merged

fix(router): make acknowledgment messages role-aware per agent type#616
zbigniewsobiecki merged 1 commit intodevfrom
fix/role-aware-ack-messages

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Mar 6, 2026

Summary

  • Root cause: ACK_SYSTEM_PROMPT in src/router/ackMessageGenerator.ts only contained investigation/review-oriented example phrases ("checking", "looking into", "dig into"), biasing ALL agent acknowledgment messages toward review language regardless of which agent was triggered.
  • Updated the system prompt with role-categorized example phrases (implementation → building/coding language, planning → design/mapping language, review → checking/examining language, splitting → breaking-down language, debug → tracing/investigating language).
  • Added an explicit role-matching instruction to the user prompt so the LLM is reminded of the agent's specific role when generating the message.
  • Added 4 new unit tests verifying the LLM receives correct role-specific prompt content for different agent types.

Card: https://trello.com/c/rUBjpU61

Test plan

  • All 37 existing tests pass with no regressions
  • 4 new tests verify system prompt contains role-category examples
  • 4 new tests verify user prompt contains role reinforcement text per agent type (implementation, review, splitting)
  • Lint and type checks pass

🤖 Generated with Claude Code

Update ACK_SYSTEM_PROMPT with role-categorized example phrases (implementation,
planning, review, splitting, debug, feedback) and add an explicit role-matching
instruction to the user prompt so the LLM generates language appropriate to each
agent's action rather than defaulting to investigation/review phrasing for all agents.

Closes https://trello.com/c/rUBjpU61

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nhopeatall
Copy link
Copy Markdown
Collaborator

🤖 On it — checking the ack messages for PR 616

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Clean, well-scoped fix to a real problem (all ack messages sounding like review-agent messages). The system prompt now covers all agent role categories, and the user prompt reinforcement ensures the LLM gets a clear signal about which role it's generating for. Tests cover the important assertion points. No issues found.

@zbigniewsobiecki zbigniewsobiecki merged commit 5cd4839 into dev Mar 6, 2026
6 checks passed
@zbigniewsobiecki zbigniewsobiecki deleted the fix/role-aware-ack-messages branch March 16, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants