feat(web): improve Work Item Runs UI with chronological sorting and direct navigation#780
Merged
feat(web): improve Work Item Runs UI with chronological sorting and direct navigation#780
Conversation
nhopeatall
approved these changes
Mar 13, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
LGTM — clean, well-scoped PR that improves the Work Item Runs UX with chronological sorting, new Engine/Model columns, and simplified navigation by replacing expandable rows with direct navigation.
Verified:
- Sort order change (
desc→asc): BothgetRunsByWorkItemandgetRunsForPRare only consumed by their respective tRPC routers → frontend pages. No other callers are affected. Integration tests don't assert on sort order, confirmed by passing CI. - Engine/Model columns: The
enrichedRunSelectinrunsRepository.tsalready includesengineandmodelfields, so the data flows correctly from DB → tRPC → frontend. TheWorkItemRuninterface update (engine: string,model: string | null) matches the DB schema. - Navigation simplification: The removed
ExpandedRunsRow(113 lines), expand/collapse state, andActivityLinkare fully replaced byuseNavigatewith correct route params for both work-item and PR types. The ~38% code reduction is a clear win with no loss of functionality — users just navigate directly instead of expanding inline. - All CI checks pass (lint, typecheck, 4589 tests, Docker builds, integration tests).
One minor pre-existing observation (not blocking): The clickable <tr> rows have an onKeyDown handler but no tabIndex attribute, so they aren't keyboard-focusable. This existed before this PR and is not a regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved the Work Item Runs page and project Work tab with better UX and chronological ordering:
Changes
Backend (runsRepository.ts)
getRunsByWorkItem()to sort ascending bystartedAt(oldest first)getRunsForPR()to sort ascending bystartedAt(oldest first)Frontend - Work Item Runs Table (work-item-runs-table.tsx)
engineandmodelfields toWorkItemRuninterfaceFrontend - Project Work Table (project-work-table.tsx)
ExpandedRunsRowcomponent (113 lines)WorkItemRowto navigate on click instead of toggling expandTesting
Links