Skip to content

feat(dashboard): remove Global Credentials page and listAll endpoint#785

Merged
aaight merged 1 commit intodevfrom
feature/remove-global-credentials
Mar 13, 2026
Merged

feat(dashboard): remove Global Credentials page and listAll endpoint#785
aaight merged 1 commit intodevfrom
feature/remove-global-credentials

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Mar 13, 2026

Summary

  • Remove the superadmin-only Global Credentials page at /global/credentials (no use case for seeing credentials across all organizations)
  • Remove the credentials.listAll tRPC endpoint and listAllCredentials repository function since they have no consumers
  • Clean up showOrg prop and organization column from CredentialsTable component
  • Remove stale listAll query invalidations from credential form dialog and credentials table

Changes

  • Deleted web/src/routes/global/credentials.tsx — removes GlobalCredentialsPage and route definition
  • Modified web/src/routes/route-tree.ts — removed globalCredentialsRoute import and from route tree
  • Modified web/src/components/layout/sidebar.tsx — removed "Global Credentials" entry from globalNav
  • Modified web/src/components/settings/credentials-table.tsx — removed showOrg prop, orgName field, org column, and listAll cache invalidation
  • Modified web/src/components/settings/credential-form-dialog.tsx — removed listAll cache invalidation
  • Modified src/api/routers/credentials.ts — removed listAll procedure and superAdminProcedure import
  • Modified src/db/repositories/credentialsRepository.ts — removed listAllCredentials function, section comment, and organizations schema import

Test plan

  • tests/unit/api/routers/credentials.test.ts — all 18 tests pass (list, create, update, delete, verifyGithubIdentity)
  • npm run typecheck — zero errors
  • npm run lint — zero errors

Trello card: https://trello.com/c/QuL0UZIU/316-lets-remove-global-credentials-feature-from-dashboard-ui-there-is-no-usecase-for-superadmin-to-see-credentials-of-all-organizati

🤖 Generated with Claude Code

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Clean removal of the unused Global Credentials feature. All references (route, sidebar entry, tRPC endpoint, repository function, showOrg prop, listAll cache invalidations) are fully cleaned up with no dangling imports or dead code left behind. CI is green.

@aaight aaight merged commit fa1aa91 into dev Mar 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants