feat(dashboard): remove Global Credentials page and listAll endpoint#785
Merged
feat(dashboard): remove Global Credentials page and listAll endpoint#785
Conversation
nhopeatall
approved these changes
Mar 13, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Clean removal of the unused Global Credentials feature. All references (route, sidebar entry, tRPC endpoint, repository function, showOrg prop, listAll cache invalidations) are fully cleaned up with no dangling imports or dead code left behind. CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/global/credentials(no use case for seeing credentials across all organizations)credentials.listAlltRPC endpoint andlistAllCredentialsrepository function since they have no consumersshowOrgprop and organization column fromCredentialsTablecomponentlistAllquery invalidations from credential form dialog and credentials tableChanges
web/src/routes/global/credentials.tsx— removesGlobalCredentialsPageand route definitionweb/src/routes/route-tree.ts— removedglobalCredentialsRouteimport and from route treeweb/src/components/layout/sidebar.tsx— removed "Global Credentials" entry fromglobalNavweb/src/components/settings/credentials-table.tsx— removedshowOrgprop,orgNamefield, org column, andlistAllcache invalidationweb/src/components/settings/credential-form-dialog.tsx— removedlistAllcache invalidationsrc/api/routers/credentials.ts— removedlistAllprocedure andsuperAdminProcedureimportsrc/db/repositories/credentialsRepository.ts— removedlistAllCredentialsfunction, section comment, andorganizationsschema importTest plan
tests/unit/api/routers/credentials.test.ts— all 18 tests pass (list, create, update, delete, verifyGithubIdentity)npm run typecheck— zero errorsnpm run lint— zero errorsTrello card: https://trello.com/c/QuL0UZIU/316-lets-remove-global-credentials-feature-from-dashboard-ui-there-is-no-usecase-for-superadmin-to-see-credentials-of-all-organizati
🤖 Generated with Claude Code