fix(runLink): remove horizontal rule from run link footer#796
Merged
Conversation
nhopeatall
approved these changes
Mar 14, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Straightforward removal of the --- horizontal rule from both buildRunLink and buildWorkItemRunsLink. The two leading newlines (\n\n) are preserved and continue to provide adequate visual separation in all call sites (PR comments, reviews, progress updates, ack messages). Test regex updated correctly. All CI checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
---markdown horizontal rule frombuildRunLinkandbuildWorkItemRunsLinkinsrc/utils/runLink.ts\n\n) for spacing above the 🕵️ footerTrello card: https://trello.com/c/nrJ54yCy/329-remove-horizontal-line-from-run-link-footer-use-empty-line-for-spacing
Changes
src/utils/runLink.ts— Removed---\nfrom bothbuildRunLink(line 68) andbuildWorkItemRunsLink(line 98)tests/unit/utils/runLink.test.ts— Updated test description and regex from/^\n\n---\n/to/^\n\n🕵️/Test plan
npx vitest run tests/unit/utils/runLink.test.ts— all 20 tests passnpm run lint— no issuesnpm run typecheck— no errors🤖 Generated with Claude Code