Skip to content

fix(runLink): remove horizontal rule from run link footer#796

Merged
aaight merged 1 commit intodevfrom
fix/remove-hr-from-run-link-footer
Mar 14, 2026
Merged

fix(runLink): remove horizontal rule from run link footer#796
aaight merged 1 commit intodevfrom
fix/remove-hr-from-run-link-footer

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Mar 14, 2026

Summary

  • Remove the --- markdown horizontal rule from buildRunLink and buildWorkItemRunsLink in src/utils/runLink.ts
  • Keep the two leading newlines (\n\n) for spacing above the 🕵️ footer
  • Update the unit test regex assertion to match the new format

Trello card: https://trello.com/c/nrJ54yCy/329-remove-horizontal-line-from-run-link-footer-use-empty-line-for-spacing

Changes

  • src/utils/runLink.ts — Removed ---\n from both buildRunLink (line 68) and buildWorkItemRunsLink (line 98)
  • tests/unit/utils/runLink.test.ts — Updated test description and regex from /^\n\n---\n/ to /^\n\n🕵️/

Test plan

  • npx vitest run tests/unit/utils/runLink.test.ts — all 20 tests pass
  • npm run lint — no issues
  • npm run typecheck — no errors

🤖 Generated with Claude Code

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Straightforward removal of the --- horizontal rule from both buildRunLink and buildWorkItemRunsLink. The two leading newlines (\n\n) are preserved and continue to provide adequate visual separation in all call sites (PR comments, reviews, progress updates, ack messages). Test regex updated correctly. All CI checks pass.

@aaight aaight merged commit a739d6e into dev Mar 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants