feat(tests): use describe.concurrent() on independent test suites#830
Merged
feat(tests): use describe.concurrent() on independent test suites#830
Conversation
nhopeatall
approved these changes
Mar 14, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - the describe.concurrent() changes are confined to independent suites, and the touched tests remain stable under concurrent execution. I verified the 10 modified files pass as a set (186 tests) and they stayed green across 10 repeated runs.
🕵️ codex · gpt-5.4 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
describe()blocks (across 10 files) todescribe.concurrent()inconfig/,utils/, andagents/definitions/directoriesFiles changed
config/ (6 files):
customModels.test.ts— pure validation, no mocksintegrationRoles.test.ts— pure validation, no mocks (2 top-level describes)rateLimits.test.ts— pure validation, no mocksreviewConfig.test.ts— pure validation, no mocksretryConfig.test.ts— factory function for local mocks only (createMockLogger()), no shared stateschema.test.ts— pure validation, no mocks (2 top-level describes)utils/ (2 files):
prUrl.test.ts— pure string/regex functions, no mocks (2 top-level describes)llmMetrics.test.ts— local mock objects created per-test, no shared stateagents/definitions/ (2 files):
schema.test.ts— pure Zod schema validation, no mocks (5 top-level describes)strategies.test.ts— pure registry lookup, no mocksExclusions (per acceptance criteria)
Files intentionally excluded:
vi.useFakeTimers():configCache.test.ts,lifecycle.test.ts,webhookLogger.test.tshintConfig.test.ts,statusUpdateConfig.test.ts,agentMessages.test.ts,cascadeEnv.test.ts,llmEnv.test.ts,llmLogging.test.ts,squintDb.test.ts,compactionConfig.test.tsloader.test.ts(callsclearDefinitionCache()inside a test),contextSteps.test.tsbackends/,triggers/— too many mock interactions (out of scope per card)Testing
https://trello.com/c/QoOehWQ0/343-as-a-developer-i-want-describeconcurrent-on-independent-test-suites-so-that-tests-within-a-file-run-in-parallel
🕵️ claude-code · claude-sonnet-4-6 · run details