Conversation
nhopeatall
approved these changes
Mar 14, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - this refactor cleanly moves the shared prompt/context helpers without changing engine call sites or behavior. The backward-compatible shims remain in place, CI is green, and the backend unit coverage for these prompt builders/context offloading still passes.
🕵️ codex · gpt-5.4 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
offloadLargeContext,cleanupContextFiles, andbuildInlineContextSectionfromsrc/backends/claude-code/contextFiles.tstosrc/backends/shared/contextFiles.tsbuildSystemPrompt,buildTaskPrompt, andbuildToolGuidancefromsrc/backends/nativeTools.tstosrc/backends/shared/nativeToolPrompts.tssrc/backends/contextFiles.tsto re-export from sharedsrc/backends/shared/contextFiles.tsCloses: https://trello.com/c/pq3Vm1a6/349-as-a-developer-i-want-context-files-and-prompt-building-moved-to-shared-so-that-all-native-tool-engines-use-common-modules
Test plan
claude-code-contextFiles.test.tstests passnpm run typecheck)npm run lint)index.tsfiles compile with no import changes needed (shims ensure backward compat)postComment.test.ts,github.test.ts, andmisc.test.tsfailures are pre-existing onorigin/devand unrelated to this refactor🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details