Skip to content

fix(sidebar): move GLOBAL section below SETTINGS for superadmin users#846

Merged
aaight merged 1 commit intodevfrom
fix/sidebar-global-below-settings
Mar 15, 2026
Merged

fix(sidebar): move GLOBAL section below SETTINGS for superadmin users#846
aaight merged 1 commit intodevfrom
fix/sidebar-global-below-settings

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Mar 15, 2026

Summary

  • Reorders sidebar nav sections so GLOBAL appears below SETTINGS instead of above it
  • Moves the Settings header + settingsNav.map(...) block to appear before the superadmin-only Global block
  • The separator before Global remains inside the conditional block so it only renders for superadmins (no double separators for non-superadmin users)

Changes

Single file change in web/src/components/layout/sidebar.tsx:

  • Settings section now renders after Projects (with unconditional separator)
  • Global section (superadmin only) now renders last, after Settings (with its own conditional separator)

Test plan

  • Log in as superadmin — verify sidebar order: Runs → Projects → Settings → Global
  • Log in as non-superadmin — verify sidebar order: Runs → Projects → Settings (no Global section)
  • Open mobile sidebar (narrow viewport) — verify same order applies
  • Confirm no double separators for non-superadmin users

Fixes: https://trello.com/c/69b66e58ebec0ec84b8c2633

🤖 Generated with Claude Code

🕵️ claude-code · claude-sonnet-4-6 · run details

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward reorder of two existing JSX blocks. Settings now renders before the superadmin-only Global section, matching the desired sidebar order (Runs → Projects → Settings → Global). The Global separator stays inside the conditional so non-superadmin users see no extra separator. All CI checks pass.

🕵️ claude-code · claude-opus-4-6 · run details

@aaight aaight merged commit 09996f7 into dev Mar 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants