Conversation
…cked chart, cost formatting
nhopeatall
approved these changes
Mar 16, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
Clean UI polish PR — sidebar reordering, compact forms with tooltip help icons, ms→min conversion for watchdog timeout, stacked bar chart replacing Recharts BarChart, and two-tier cost formatting. All changes are straightforward, well-tested, and CI is fully green.
Notes
- ms↔min conversion is correct:
msToMinutesusesMath.round(ms / 60000),minutesToMsusesparseInt * 60000. The dirty-state check, reset, and submit all use the new helpers consistently. formatCostSummary(2 decimal) is correctly applied only to summary/aggregate contexts (stats summary, work table, cost chart center label), whileformatCost(4 decimal) is preserved for individual run detail views (run summary card, runs table, LLM call list). Good separation.- Duration chart replacement — swapping Recharts vertical BarChart for a plain CSS flex bar is a nice simplification. The
titleattribute on segments preserves the tooltip data that the Recharts<Tooltip>component previously provided. Recharts remains a dependency viawork-item-cost-chart.tsxandproject-work-duration-chart.tsx, so no orphaned dependency. - Sidebar reorder — test updated to match new order. The
ProjectSectiontype union andProjectSectionRoutetype are unordered, so no type changes needed. - Work item runs page cleanup — removed stats summary block and work item ID line. The charts and runs table below still provide all the same data.
LGTM — no correctness, security, or architectural issues found.
🕵️ claude-code · claude-opus-4-6 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CardDescriptionfrom all Cards, replaced withHelpCircletooltip icons on card titlesclassName="w-32"to Budget, Max In-Flight, Max Session Time, Progress Interval, and Max Iterations fieldsstep="1"to Progress Interval and Max Session Time inputswork-item-duration-chart.tsxwith a single horizontal flex bar using percentage widths per run, plus detail list belowformatCostSummary(.toFixed(2)) toutils.ts; used in stats summary, cost chart center label, and work table; keptformatCost(.toFixed(4)) for individual run detail viewsWork Item ID: {workItemId}line and the total/completed/failed stats summary blockTest plan
project-navigation.test.tsorder matches new sidebar,utils.test.tscoversformatCostSummaryCard: https://trello.com/c/OqSDjb5B/426-a-bunch-of-ui-updates
Work Item: https://trello.com/c/69b80fdb802debbd0b7d183b
🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details