Skip to content

feat(ui): reorder engine/model/iterations fields — engine first across all 3 locations#903

Merged
aaight merged 1 commit intodevfrom
feature/ui-engine-model-ordering
Mar 16, 2026
Merged

feat(ui): reorder engine/model/iterations fields — engine first across all 3 locations#903
aaight merged 1 commit intodevfrom
feature/ui-engine-model-ordering

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Mar 16, 2026

Summary

  • project-harness-form.tsx: Reordered fields from Engine → EngineSettings → Model+MaxIter (2-col) to Engine → Model → EngineSettings → MaxIterations (standalone)
  • project-agent-configs.tsx: Reordered Engine tab from Model+MaxIter (2-col) → MaxConcurrency+Engine (2-col) → EngineSettings to Engine → Model → EngineSettings → MaxIter+MaxConcurrency (2-col)
  • agent-config-form-dialog.tsx: Reordered from AgentType → Model+MaxIter (2-col) → MaxConcurrency → Engine → EngineSettings to AgentType → Engine → Model → EngineSettings → MaxIter+MaxConcurrency (2-col)
  • project-agent-configs.tsx: Renamed table column header from 'Model / Engine' to 'Engine / Model' and swapped display order in AgentRow

Test plan

  • Verify project Engine tab shows: Agent Engine → Model → (Engine Settings, if applicable) → Max Iterations
  • Verify per-agent config Engine tab shows: Engine → Model → (Engine Settings, if applicable) → Max Iterations + Max Concurrency (2-col)
  • Verify global agent config dialog shows: Agent Type → Engine → Model → (Engine Settings, if applicable) → Max Iterations + Max Concurrency (2-col)
  • Verify agents list table header says 'Engine / Model' and rows show engine first
  • Test engine-model interaction: selecting Claude Code/Codex shows dropdown for model, LLMist/OpenCode shows text input
  • Verify engine settings appear/disappear correctly when engine is changed

Trello: https://trello.com/c/PmXGjOwj/429-lets-rethink-the-ui-wherever-we-pick-the-engine-model-and-max-iterations-in-the-dashboard-whats-most-important-is-the-engine-and

🤖 Generated with Claude Code

🕵️ claude-code · claude-sonnet-4-6 · run details

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Pure UI reordering that consistently places Engine first across all three locations (project harness form, per-agent config tab, global agent config dialog). Field ordering is now uniform: Engine → Model → Engine Settings → remaining numeric fields. The table header and row display order in the agent list are updated to match. No logic, props, or state management changes — just JSX element repositioning. All CI checks pass.

🕵️ claude-code · claude-opus-4-6 · run details

@aaight aaight merged commit 2b35576 into dev Mar 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants