Skip to content

fix: misc UI and trigger cleanup#905

Merged
aaight merged 1 commit intodevfrom
feature/misc-updates-69b818b8
Mar 16, 2026
Merged

fix: misc UI and trigger cleanup#905
aaight merged 1 commit intodevfrom
feature/misc-updates-69b818b8

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Mar 16, 2026

Summary

  • Remove slug (ID) and Repository fields from Project Identity card in General tab
  • Simplify run links description to remove CASCADE_DASHBOARD_URL env var reference
  • Change lifecycle automation defaultValue from true to false for prReadyToMerge and prMerged
  • Remove pm:comment-mention trigger from planning agent definition (belongs in respond-to-planning-comment)
  • Remove scm:pr-ready-to-merge and scm:pr-merged from review agent definition (non-agentic, lifecycle-only)
  • Create isLifecycleTriggerEnabled helper reading from project_integrations.triggers JSONB
  • Update pr-ready-to-merge and pr-merged trigger handlers to use lifecycle store instead of agent trigger configs
  • Update tests to reflect all changes and add lifecycle helper tests

Test plan

  • All unit tests pass (5415 tests)
  • Lint clean, type check passing
  • Lifecycle triggers (prReadyToMerge/prMerged) now correctly read from project_integrations.triggers with default disabled
  • Planning agent no longer shows pm:comment-mention trigger (routed to respond-to-planning-comment)
  • Review agent no longer shows lifecycle triggers in Agent Configs tab

Closes https://trello.com/c/hEfkpKnH/430-misc-updates

🤖 Generated with Claude Code

🕵️ claude-code · claude-sonnet-4-6 · run details

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

LGTM — Clean, well-scoped cleanup that correctly separates lifecycle triggers from agent trigger configs.

The changes are consistent and well-reasoned:

  1. Lifecycle trigger source-of-truth migration: prReadyToMerge and prMerged now read from project_integrations.triggers JSONB (via new isLifecycleTriggerEnabled helper) instead of the agent_trigger_configs table. This is the right call — these are non-agentic lifecycle operations that don't belong in agent trigger configs.

  2. Agent definition cleanup: Removing pm:comment-mention from planning agent (correctly lives in respond-to-planning-comment.yaml) and removing lifecycle triggers from review agent (they were never agent-driven). Both verified by tracing where these events are actually routed.

  3. Default value fix: Changing LIFECYCLE_TRIGGERS defaultValue from true to false aligns the frontend with the backend's default-disabled behavior in isLifecycleTriggerEnabled.

  4. UI simplification: Removing slug/repo from Project Identity card and simplifying run links description are straightforward UI cleanup. The biome-ignore removal is justified by the reduced complexity after removing ~30 lines of conditional JSX.

  5. Test coverage: New lifecycle-check.test.ts covers all edge cases (enabled, disabled, missing key, null integration, null triggers column, logging behavior). Existing tests properly updated to mock the new helper.

All CI checks pass.

🕵️ claude-code · claude-opus-4-6 · run details

@aaight aaight merged commit 7dac502 into dev Mar 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants