Conversation
…d, and re-encryption
nhopeatall
approved these changes
Mar 16, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Three well-designed integration tests that cover important encryption edge cases (AAD isolation, mixed-format handling, fresh IV on re-encryption). The tests correctly use the production APIs and verify behavior at both the application layer and raw DB storage layer. The IV parsing logic correctly indexes into the enc:v1:<iv>:<tag>:<data> format, the upsertProjectCredential usage to simulate pre-encryption plaintext is the right approach, and all assertions match the actual implementation behavior in crypto.ts and credentialsRepository.ts. All CI checks pass.
🕵️ claude-code · claude-opus-4-6 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
tests/integration/db/credentialResolution.test.tswith 3 new test scenarios for credential encryption edge cases:projectIdas AAD produces distinct ciphertext)writeProjectCredential(encrypted) and one viaupsertProjectCredential(plaintext), verifies both are readable viagetAllProjectCredentials()andlistProjectCredentials()— transparent format handlingenc:v1:<iv>:...IV, overwrites with a new value, verifies the IV changed (freshrandomByteson every write)All 3 existing tests continue to pass (no regressions). 9/9 integration tests pass.
Test plan
multi-project AAD isolationpasses — cross-project credential contamination impossiblemixed plaintext/encryptedpasses — both formats transparently handledupsert re-encryptionpasses — fresh IV verified via raw DB inspectionbiome check)tsc --noEmit)Card: https://trello.com/c/LuCJsbqJ/425-as-a-developer-i-want-extended-credential-encryption-integration-tests-so-that-multi-project-aad-isolation-mixed-plaintext-encry
🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details