Conversation
nhopeatall
approved these changes
Mar 16, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Clean dead code removal. All deleted functions (, , , , , , , , , ) have zero remaining references in both src/ and tests/. Corresponding test blocks were properly removed and imports cleaned up. CI is green across all checks.
🕵️ claude-code · claude-opus-4-6 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes dead code identified in Story 3 — unused utility functions that have zero production callers and were misleading future contributors.
src/utils/llmMetrics.ts): RemovedestimateInputTokens,logLLMMetrics,logLLMCallStart,LLMCallMetricsinterface, andSimpleLoggerinterface. KeptcalculateCostandMODEL_PRICING(actively used).src/triggers/github/utils.ts): RemovedextractTrelloCardUrl,hasTrelloCardUrl,requireTrelloCardId, andrequireWorkItemId. KeptextractTrelloCardId,extractJiraIssueKey,extractWorkItemId,evaluateAuthorMode, andresolveWorkItemId(all actively used).src/pm/media.ts): RemovedmediaToBase64DataUri(zero production callers).llmMetrics.test.ts,github-utils.test.ts, andmedia.test.ts.Test plan
npm run lint:fix— no issuesnpm run typecheck— zero errorsnpm test— all 293 test files, 5422 tests passinggrepconfirms zero remaining references to removed function names insrc/Closes: https://trello.com/c/MuA2T4at/436-as-a-developer-i-want-unused-utility-functions-removed-from-metrics-trigger-utils-and-media-modules-so-that-dead-code-does-not-m
🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details