Conversation
nhopeatall
approved these changes
Mar 16, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
LGTM — Clean, mechanical upgrade of ~28 mutation commands to use this.success() (green ✓ prefix) and this.withSpinner() for loading indicators. The changes are consistent, backward-compatible, and well-structured.
Notes
- All 28 commands follow the same pattern: wrap tRPC
.mutate()withthis.withSpinner(), replacethis.log()withthis.success(), and add contextual details (resource name/ID) to success messages. login.tsandlogout.tscorrectly usechalk.green('✓ ...')directly since they extend oclif'sCommandbase (notDashboardCommand) — they don't have access tothis.success(), and this is appropriate since they don't need a tRPC client.--jsonmode is properly preserved:withSpinnerin the base class auto-detects--jsonand passessilent: trueto suppress the spinner, and allif (flags.json)guards still return before hittingthis.success().- The
withSpinnerimplementation correctly stops the spinner on both success and error (re-throws afterspinner.stop()), so error handling viathis.handleError(err)is unaffected. - CI checks (lint, typecheck, 5480 unit tests, integration tests, Docker builds) all pass.
- Base class methods
success(),info(), andwithSpinner()are already covered by unit tests intests/unit/cli/dashboard/base.test.ts.
🕵️ claude-code · claude-opus-4-6 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/cli/dashboard/to usethis.success()(green ✓ prefix) instead of barethis.log()this.withSpinner()to show loading indicators during network operations✓ Logged in as Alice (alice@example.com) at http://localhost:3000✓ Created project 'my-project' (repo: owner/repo)✓ Updated project 'my-project'✓ Agent run triggered — project: X, agent: Y/✓ Retry triggered — run ID: abc123✓ Deleted project 'my-project'✓ Logged out.--jsonmode continues to output raw JSON without emoji prefixes (backward compatible)Affected Commands
login,logout— added chalk green prefixruns/trigger,runs/retry,runs/cancel— success + spinnerprojects/create,projects/update,projects/delete— success + spinnerprojects/credentials-set,projects/credentials-delete— success + spinnerprojects/integration-set,projects/trigger-set— success + spinnerusers/create,users/update,users/delete— success + spinnerorg/update— success + spinneragents/create,agents/update,agents/delete— success + spinnerdefinitions/create,definitions/update,definitions/delete,definitions/import,definitions/reset— success + spinnerprompts/set-partial,prompts/reset-partial— success + spinnerwebhooks/create,webhooks/delete— success + spinnerTest plan
npm run typecheck)npm run lint)npm run test:unit)--jsonmode outputs raw JSON (no emoji prefix) — preserved in all commandsTrello card: https://trello.com/c/XbzMwKmu/443-as-a-user-i-want-polished-success-messages-with-context-so-that-i-can-confirm-what-was-created-changed
🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details