Skip to content

feat(dashboard): move webhook buttons below collapsible curl blocks#933

Merged
zbigniewsobiecki merged 1 commit intodevfrom
feature/dashboard-ui-webhook-ordering
Mar 17, 2026
Merged

feat(dashboard): move webhook buttons below collapsible curl blocks#933
zbigniewsobiecki merged 1 commit intodevfrom
feature/dashboard-ui-webhook-ordering

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Mar 17, 2026

Summary

  • SCM tab (GitHub): Move "Create GitHub Webhook" button below the curl example block; wrap curl block in a collapsible <details> element
  • PM wizard (Webhook step): Move "Create Webhook" button below the collapsible curl instructions; update directional text from "above" to "below"
  • Trello credentials step: Move "Credentials stored" green banner to the very top of the step; update text from "above" to "below"

Card: https://trello.com/c/69b95fdc8cc9bc50004e8f75

Files changed

File Change
web/src/components/projects/integration-form.tsx Swap curl block & button order; wrap curl block in <details>
web/src/components/projects/pm-wizard-common-steps.tsx Swap curl block & button order; wrap curl block in <details>
web/src/components/projects/pm-wizard-trello-steps.tsx Move "Credentials stored" banner to top; update wording to "below"

Test plan

  • Navigate to Integrations → Source Control tab; verify "Create GitHub Webhook" button appears below the (now collapsible) curl block
  • Expand the <details> block and verify the curl command is readable and the Copy button works
  • Navigate to Integrations → PM → Step 5 (Webhooks); verify "Create Webhook" button appears below the collapsible curl instructions
  • For a project with stored Trello credentials, navigate to PM → Step 2 (Credentials); verify green "Credentials stored" banner appears at the top of the step
  • Verify dark mode styling is preserved across all modified sections
  • All unit tests pass (npm test — 5480 tests)
  • TypeScript type check passes (npm run typecheck)
  • Biome lint passes (npm run lint:fix)

🤖 Generated with Claude Code

🕵️ claude-code · claude-sonnet-4-6 · run details

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Clean UI reordering with no logic changes. The curl instruction blocks are correctly moved above their respective buttons and wrapped in collapsible <details> elements, directional text ("above" → "below") is consistently updated across all three files, and dark mode styling is preserved. All CI checks pass.

🕵️ claude-code · claude-opus-4-6 · run details

@zbigniewsobiecki zbigniewsobiecki merged commit 522b331 into dev Mar 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants