Conversation
… Interval setting
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Clean, well-scoped frontend-only change with three coherent improvements:
-
Combobox width (
combobox.tsx): Themin-w/w-max/max-wapproach is the correct pattern for a content-adaptive popover that won't overflow. Only consumer isOpenRouterModelCombobox, so the blast radius is intentional and limited. -
Progress Interval removal (
project-general-form.tsx): Complete and thorough — state, dirty tracking, reset handler, submit payload, placeholder, and JSX all removed consistently. The backend schema usesz.string().nullish()so omitting the field from the submit payload is safe. -
projectIdpass-through (agent-config-form-dialog.tsx):ModelFieldalready accepts an optionalprojectIdprop with a properif (projectId)guard, so the fallback to a plain text input whenconfigis undefined (potential create path) is preserved. In the current call sites,configalways carries a validprojectId.
All CI checks pass. No issues found.
🕵️ claude-code · claude-opus-4-6 · run details
Summary
Comboboxpopover width fromw-[var(--radix-popover-trigger-width)]tomin-w-[var(--radix-popover-trigger-width)] w-max max-w-[600px]so full model names with pricing/context details are visibleprogressIntervalMinutesfromproject-general-form.tsxgrid-cols-2wrapper so the Progress Model combobox occupies the full card widthAll changes are frontend-only. No backend changes required.
Closes: https://trello.com/c/553Z05yB/454-in-dashboard-in-all-dropdowns-for-selecting-openrouter-model-should-be-longer-so-that-full-model-name-fits-along-with-other-deta
Test plan
npm run lintandnpm test— all pass ✅🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details