Skip to content

feat(dashboard): widen OpenRouter model dropdowns and remove Progress Interval setting#937

Merged
aaight merged 1 commit intodevfrom
feature/wider-openrouter-dropdowns-remove-progress-interval
Mar 17, 2026
Merged

feat(dashboard): widen OpenRouter model dropdowns and remove Progress Interval setting#937
aaight merged 1 commit intodevfrom
feature/wider-openrouter-dropdowns-remove-progress-interval

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Mar 17, 2026

Summary

  • Widen OpenRouter model dropdowns — Changed Combobox popover width from w-[var(--radix-popover-trigger-width)] to min-w-[var(--radix-popover-trigger-width)] w-max max-w-[600px] so full model names with pricing/context details are visible
  • Remove Progress Interval field — Deleted state, dirty tracking, reset handler, submit payload, placeholder computation, and JSX for progressIntervalMinutes from project-general-form.tsx
  • Make Progress Model full-width — Removed the grid-cols-2 wrapper so the Progress Model combobox occupies the full card width
  • Pass projectId to ModelField in AgentConfigFormDialog — Enables the rich OpenRouter combobox (with search and pricing) instead of a plain text input in the global agent config dialog

All changes are frontend-only. No backend changes required.

Closes: https://trello.com/c/553Z05yB/454-in-dashboard-in-all-dropdowns-for-selecting-openrouter-model-should-be-longer-so-that-full-model-name-fits-along-with-other-deta

Test plan

  • Navigate to Project Settings > General — confirm the "Progress Interval" field is gone
  • Confirm the "Progress Model" OpenRouter combobox is now full-width in the Progress Monitoring card
  • Open the Progress Model dropdown — verify model names and pricing details are fully visible without truncation
  • Navigate to Project Settings > Engine — open the Model dropdown — verify it's wider and shows full model names
  • Navigate to Agent Configs tab — click an agent — open the Model dropdown — verify OpenRouter combobox appears (not a plain text input) and is sufficiently wide
  • Run npm run lint and npm test — all pass ✅

🤖 Generated with Claude Code

🕵️ claude-code · claude-sonnet-4-6 · run details

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Clean, well-scoped frontend-only change with three coherent improvements:

  1. Combobox width (combobox.tsx): The min-w/w-max/max-w approach is the correct pattern for a content-adaptive popover that won't overflow. Only consumer is OpenRouterModelCombobox, so the blast radius is intentional and limited.

  2. Progress Interval removal (project-general-form.tsx): Complete and thorough — state, dirty tracking, reset handler, submit payload, placeholder, and JSX all removed consistently. The backend schema uses z.string().nullish() so omitting the field from the submit payload is safe.

  3. projectId pass-through (agent-config-form-dialog.tsx): ModelField already accepts an optional projectId prop with a proper if (projectId) guard, so the fallback to a plain text input when config is undefined (potential create path) is preserved. In the current call sites, config always carries a valid projectId.

All CI checks pass. No issues found.

🕵️ claude-code · claude-opus-4-6 · run details

@aaight aaight merged commit 692962f into dev Mar 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants