test(cli): add unit tests for dashboard auth commands (login, logout, whoami)#938
Merged
test(cli): add unit tests for dashboard auth commands (login, logout, whoami)#938
Conversation
nhopeatall
approved these changes
Mar 17, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Well-structured unit tests that follow the established patterns (mock hoisting, oclifConfig stub, chalk identity mock) from integration-credentials.test.ts. All 14 tests cover meaningful behavior paths for login, logout, and whoami commands. CI is green.
Verified against source:
- Login success/failure paths, cookie parsing, trailing-slash stripping, and org passthrough all match
login.tsimplementation - Logout best-effort fetch, error swallowing, null-config skip, and dynamic cookie name all match
logout.ts - Whoami table/JSON output and effectiveOrgId conditional display match
whoami.ts+DashboardCommand.outputDetail/outputJson
No issues found.
🕵️ claude-code · claude-opus-4-6 · run details
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/unit/cli/dashboard/auth.test.tswith 14 tests covering login, logout, and whoami dashboard CLI commandsfetch(),saveConfig/clearConfig/loadConfig,createDashboardClient, andchalkfollowing the pattern fromintegration-credentials.test.tsoclifConfig = { runHook: vi.fn() }for oclif command instantiationWhat was implemented
Login tests (6):
serverUrl,sessionToken,cookieName, andorgIdextracted fromSet-Cookieheader--orgflag is passed through tosaveConfig--serverURLerrorfieldLogout tests (4):
clearConfigand logs success messagecascade_session_developmentetc.)Whoami tests (4):
client.auth.meand displays table output--jsonflag is seteffectiveOrgIdrow when it differs fromorgIdeffectiveOrgIdrow when it equalsorgIdTest plan
npx vitest run --project unit-core tests/unit/cli/dashboard/auth.test.ts→ 14/14 passnpm run lint:fix→ cleannpm run typecheck→ zero errorsCard
https://trello.com/c/69b9918fc9f6194971250484
🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details