test(cli): add unit tests for PM/SCM commands and cliCommandFactory

[aaight]

Summary

Closes https://trello.com/c/lyc2vG0V/463-as-a-developer-i-want-unit-tests-for-pm-scm-tool-commands-and-clicommandfactory-so-that-agent-tool-coverage-gaps-are-closed

• Add unit tests for 7 PM CLI commands: read-work-item, list-work-items, move-work-item, delete-checklist-item, update-checklist-item, create-work-item, post-comment
• Add unit tests for 8 SCM CLI commands: get-pr-details, get-pr-diff, get-pr-checks, get-pr-comments, get-ci-run-logs, post-pr-comment, reply-to-review-comment, update-pr-comment
• Add unit tests for cliCommandFactory covering all flag types, gadgetOnly exclusion, file-input resolution, owner/repo auto-resolution, and JSON output format

New test files

• tests/unit/cli/pm/pm-commands.test.ts — 19 tests
• tests/unit/cli/scm/scm-commands.test.ts — 24 tests
• tests/unit/cli/cli-command-factory.test.ts — 19 tests

Test plan

• All 62 new tests pass
• Full unit test suite passes (3514 tests across 191 files)
• Lint passes (biome check clean)
• TypeScript type check passes (zero errors)

Key decisions

• Used makeMockConfig() factory function (not a shared const) so each test gets a fresh runHook mock that isn't cleared by vi.restoreAllMocks() in afterEach
• Mocked credential-scoping dependencies (withGitHubToken, withTrelloCredentials, withJiraCredentials, createPMProvider, withPMProvider) to isolate CLI command logic — matching the pattern from file-input-flags.test.ts
• Set CASCADE_REPO_OWNER/CASCADE_REPO_NAME env vars in beforeEach for SCM tests that use auto-resolved owner/repo
• The readWorkItemDef defines includeComments with default: true, so tests verify the boolean flag correctly passes true by default and false with --no-includeComments

🤖 Generated with Claude Code

🕵️ claude-code · claude-sonnet-4-6 · run details

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[nhopeatall]

Summary

LGTM — Well-structured test suite that closes coverage gaps for PM/SCM CLI commands and cliCommandFactory. All 62 tests correctly verify CLI → core function wiring, with proper mocking of credential-scoping dependencies and core functions. CI is green.

Code Issues

Nitpick

• tests/unit/cli/cli-command-factory.test.ts:44 — Unused mockConfig const. The makeMockConfig() factory is correctly used everywhere, but the old const mockConfig on line 44 was left behind as dead code. Minor cleanup opportunity.

🕵️ claude-code · claude-opus-4-6 · run details