Skip to content

feat(dashboard): add inactive warning indicators to agents with no triggers#945

Merged
aaight merged 1 commit intodevfrom
feature/agent-inactive-warning-indicators
Mar 18, 2026
Merged

feat(dashboard): add inactive warning indicators to agents with no triggers#945
aaight merged 1 commit intodevfrom
feature/agent-inactive-warning-indicators

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Mar 18, 2026

Summary

Makes agents with zero active triggers more prominent in the Dashboard Agents list by adding visual warning indicators.

  • Amber "Inactive" badge in the Status column — replaces "Configured"/"Default" when an agent has zero active triggers, making inactive agents immediately visible at a glance
  • Amber warning icon + "None" text in the Active Triggers column — an AlertTriangle icon next to "None" with hover tooltip explaining the agent won't process any events
  • TooltipProvider wrapper around the Agents table so tooltips on warning icons work correctly

Changes

All changes are frontend-only in a single file: web/src/components/projects/project-agent-configs.tsx

  1. Added AlertTriangle from lucide-react and Tooltip, TooltipContent, TooltipProvider, TooltipTrigger from @/components/ui/tooltip.js
  2. Modified the Status <TableCell> in AgentRow — when activeTriggerCount === 0, shows an amber "Inactive" badge (bg-amber-100 text-amber-800 dark:bg-amber-900/30 dark:text-amber-400)
  3. Modified the Active Triggers <TableCell> in AgentRow — when activeTriggerCount === 0, shows an AlertTriangle icon + amber "None" text wrapped in a <Tooltip> with explanatory content
  4. Wrapped the <Table> in AgentListView with <TooltipProvider delayDuration={200}> following existing patterns in project-harness-form.tsx and project-general-form.tsx

Test plan

  • Navigate to Dashboard → Projects → [Project] → Agent Configs
  • Find or create an agent with zero active triggers (disable all triggers for an agent)
  • Verify: Amber "Inactive" badge appears in the Status column
  • Verify: Amber warning icon + "None" text appears in Active Triggers column
  • Verify: Hovering over the warning shows tooltip "No triggers configured — this agent won't process any events"
  • Verify: Agents with ≥1 active trigger still show "Configured"/"Default" badge and trigger count as before
  • Verify: Dark mode renders correctly (amber colors adjust)

Notes

  • Frontend-only change — all data (activeTriggerCount) is already computed by countActiveTriggers() in the component
  • Follows existing amber color scheme from integration-form.tsx and pm-wizard-common-steps.tsx
  • All 5949 unit tests pass, TypeScript and Biome lint checks pass

Trello card: https://trello.com/c/iPJA0bCS/468-make-agents-with-no-triggers-configured-more-prominent-in-dashboard-agents-list

🤖 Generated with Claude Code

🕵️ claude-code · claude-sonnet-4-6 · run details

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Clean, well-scoped frontend change that correctly adds visual warning indicators for inactive agents. Pattern usage (amber colors, TooltipProvider, AlertTriangle icon) is consistent with existing codebase conventions. Component hierarchy is correct (TooltipProvider wraps Table in AgentListView, Tooltip used in AgentRow child). The status badge priority change (activeTriggerCount === 0 takes precedence over config status) is a reasonable UX decision since an agent with zero triggers won't process events regardless of its configuration. All CI checks pass.

🕵️ claude-code · claude-opus-4-6 · run details

@aaight aaight merged commit b6273c1 into dev Mar 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants