Conversation
nhopeatall
approved these changes
Mar 18, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Clean, well-scoped frontend change that correctly adds visual warning indicators for inactive agents. Pattern usage (amber colors, TooltipProvider, AlertTriangle icon) is consistent with existing codebase conventions. Component hierarchy is correct (TooltipProvider wraps Table in AgentListView, Tooltip used in AgentRow child). The status badge priority change (activeTriggerCount === 0 takes precedence over config status) is a reasonable UX decision since an agent with zero triggers won't process events regardless of its configuration. All CI checks pass.
🕵️ claude-code · claude-opus-4-6 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes agents with zero active triggers more prominent in the Dashboard Agents list by adding visual warning indicators.
AlertTriangleicon next to "None" with hover tooltip explaining the agent won't process any eventsChanges
All changes are frontend-only in a single file:
web/src/components/projects/project-agent-configs.tsxAlertTrianglefromlucide-reactandTooltip, TooltipContent, TooltipProvider, TooltipTriggerfrom@/components/ui/tooltip.js<TableCell>inAgentRow— whenactiveTriggerCount === 0, shows an amber "Inactive" badge (bg-amber-100 text-amber-800 dark:bg-amber-900/30 dark:text-amber-400)<TableCell>inAgentRow— whenactiveTriggerCount === 0, shows anAlertTriangleicon + amber "None" text wrapped in a<Tooltip>with explanatory content<Table>inAgentListViewwith<TooltipProvider delayDuration={200}>following existing patterns inproject-harness-form.tsxandproject-general-form.tsxTest plan
Notes
activeTriggerCount) is already computed bycountActiveTriggers()in the componentintegration-form.tsxandpm-wizard-common-steps.tsxTrello card: https://trello.com/c/iPJA0bCS/468-make-agents-with-no-triggers-configured-more-prominent-in-dashboard-agents-list
🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details