Conversation
nhopeatall
approved these changes
Mar 21, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — All 5 test files are well-structured, correctly mirror the source implementations, and follow the established createPR.test.ts pattern (vi.mock before imports, vi.mocked() helper, clearAllMocks in beforeEach, Awaited<ReturnType<...>> type casts). Mock setups accurately reflect the githubClient methods used by each source function. The postPRComment test appropriately mocks the buildRunLinkFooterFromEnv dependency and verifies the footer-appending logic. All CI checks pass.
🕵️ claude-code · claude-opus-4-6 · run details
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/gadgets/github/core/createPR.test.tspattern: mockinggithubClientviavi.mockFiles Added
tests/unit/gadgets/github/core/getPRDetails.test.ts— tests success (formatted output with title/state/branch/URL/body, empty body fallback) and error pathtests/unit/gadgets/github/core/postPRComment.test.ts— tests success with and without run link footer, error path; mocks bothgithubClientandbuildRunLinkFooterFromEnvtests/unit/gadgets/github/core/replyToReviewComment.test.ts— tests success (returns URL) and error pathtests/unit/gadgets/github/core/updatePRComment.test.ts— tests success (returns id and URL) and error pathtests/unit/gadgets/github/core/getPRDiff.test.ts— tests success with patch, files without patch (binary/too large), empty file list, and error pathTest plan
npm test)npm run lint)Trello card: https://trello.com/c/W6fFy4Wy/492-as-a-developer-i-want-unit-tests-for-gadgets-github-core-untested-files-so-that-pr-details-comments-replies-and-diff-gadget-func
🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details