Skip to content

feat(backends): make claude-code the default agent engine#975

Merged
aaight merged 2 commits intodevfrom
feature/claude-code-default-engine
Mar 22, 2026
Merged

feat(backends): make claude-code the default agent engine#975
aaight merged 2 commits intodevfrom
feature/claude-code-default-engine

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Mar 22, 2026

Summary

  • Change default agent engine from llmist to claude-code across the codebase
  • Update PROJECT_DEFAULTS.agentEngine constant in src/config/schema.ts
  • Update DEFAULT_ENGINE fallback in src/backends/resolution.ts
  • Reorder DEFAULT_ENGINE_CATALOG so claude-code is first
  • Update frontend fallback strings, tools, seed config, and documentation
  • Update all test assertions that expected 'llmist' as the default

Changes

Core defaults

  • src/config/schema.ts: agentEngine: 'llmist''claude-code'
  • src/backends/resolution.ts: DEFAULT_ENGINE = 'llmist''claude-code', updated JSDoc
  • src/backends/catalog.ts: Moved CLAUDE_CODE_ENGINE_DEFINITION to index [0], LLMIST_ENGINE_DEFINITION to [1]

Frontend & tools

  • web/src/components/projects/project-agent-configs.tsx: Fallback ?? 'llmist'?? 'claude-code'
  • web/src/components/projects/projects-table.tsx: Fallback ?? 'llmist'?? 'claude-code'
  • tools/resolve-config.ts: Fallback ?? 'llmist'?? 'claude-code'
  • config/projects.json: Seed example default "llmist""claude-code"

Documentation

  • docs/getting-started.md: Updated engine table, moved (default) annotation to claude-code
  • README.md: Updated feature list and Key Concepts section
  • CLAUDE.md: Updated Claude Code Engine section description

Tests (13 files total)

  • Updated schema, resolution, catalog, projects router, configRepository, and CLI dashboard test fixtures/assertions

Notes

  • No DB migration needed: agent_engine column is nullable; NULL uses the code default
  • Existing NULL projects will now default to claude-code — requires CLAUDE_CODE_OAUTH_TOKEN
  • Easy rollback: Revert the two constants in schema.ts and resolution.ts

Closes https://trello.com/c/69c00f6da5a200c2ecfecf1c

🕵️ claude-code · claude-sonnet-4-6 · run details

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Clean, well-scoped default-swap with consistent updates across core constants, frontend fallbacks, docs, and tests. All CI checks pass. Two stale references to llmist as the default/fallback were missed in files not touched by this PR.

Should Fix

  • src/agents/registry.ts:14 — The JSDoc on the runAgent function still says 3. Fallback: 'llmist' but DEFAULT_ENGINE in resolution.ts is now 'claude-code'. This is the authoritative description of the engine resolution order and should be updated to match.

  • docs/getting-started.md:138 — The subheading #### LLMist engine (default) was not updated. The engine table and intro paragraph (lines ~207-218, which are in this PR) were correctly changed, but the credential setup section's subheading on line 138 still labels LLMist as the default engine. The corresponding #### Claude Code engine heading (line 162) should also get (default) added for consistency.

Neither of these is in the PR diff, so adding as body-level notes rather than inline comments.

🕵️ claude-code · claude-opus-4-6 · run details

Update the JSDoc in src/agents/registry.ts to reflect the actual fallback
engine ('claude-code' not 'llmist'), and fix the credential setup subheadings
in docs/getting-started.md to remove '(default)' from the LLMist heading and
add it to the Claude Code heading.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

LGTM — Clean, comprehensive default-value change from llmist to claude-code across the entire codebase.

The two source-of-truth constants (PROJECT_DEFAULTS.agentEngine in schema.ts and DEFAULT_ENGINE in resolution.ts) are updated, and all downstream consumers — frontend fallbacks, seed config, documentation, and 13 test files — are updated consistently. No stale 'llmist' fallbacks remain anywhere in the codebase (verified via search). No DB migration is needed since agent_engine is nullable and NULL falls through to the code default.

The operational impact (existing NULL projects will now default to claude-code, requiring CLAUDE_CODE_OAUTH_TOKEN) is correctly documented in the PR description.

All CI checks pass.

🕵️ claude-code · claude-opus-4-6 · run details

@aaight aaight merged commit 4777a37 into dev Mar 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants