feat(backends): make claude-code the default agent engine#975
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
Clean, well-scoped default-swap with consistent updates across core constants, frontend fallbacks, docs, and tests. All CI checks pass. Two stale references to llmist as the default/fallback were missed in files not touched by this PR.
Should Fix
-
src/agents/registry.ts:14 — The JSDoc on the
runAgentfunction still says3. Fallback: 'llmist'butDEFAULT_ENGINEinresolution.tsis now'claude-code'. This is the authoritative description of the engine resolution order and should be updated to match. -
docs/getting-started.md:138 — The subheading
#### LLMist engine (default)was not updated. The engine table and intro paragraph (lines ~207-218, which are in this PR) were correctly changed, but the credential setup section's subheading on line 138 still labels LLMist as the default engine. The corresponding#### Claude Code engineheading (line 162) should also get(default)added for consistency.
Neither of these is in the PR diff, so adding as body-level notes rather than inline comments.
🕵️ claude-code · claude-opus-4-6 · run details
Update the JSDoc in src/agents/registry.ts to reflect the actual fallback
engine ('claude-code' not 'llmist'), and fix the credential setup subheadings
in docs/getting-started.md to remove '(default)' from the LLMist heading and
add it to the Claude Code heading.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
LGTM — Clean, comprehensive default-value change from llmist to claude-code across the entire codebase.
The two source-of-truth constants (PROJECT_DEFAULTS.agentEngine in schema.ts and DEFAULT_ENGINE in resolution.ts) are updated, and all downstream consumers — frontend fallbacks, seed config, documentation, and 13 test files — are updated consistently. No stale 'llmist' fallbacks remain anywhere in the codebase (verified via search). No DB migration is needed since agent_engine is nullable and NULL falls through to the code default.
The operational impact (existing NULL projects will now default to claude-code, requiring CLAUDE_CODE_OAUTH_TOKEN) is correctly documented in the PR description.
All CI checks pass.
🕵️ claude-code · claude-opus-4-6 · run details
Summary
llmisttoclaude-codeacross the codebasePROJECT_DEFAULTS.agentEngineconstant insrc/config/schema.tsDEFAULT_ENGINEfallback insrc/backends/resolution.tsDEFAULT_ENGINE_CATALOGsoclaude-codeis first'llmist'as the defaultChanges
Core defaults
src/config/schema.ts:agentEngine: 'llmist'→'claude-code'src/backends/resolution.ts:DEFAULT_ENGINE = 'llmist'→'claude-code', updated JSDocsrc/backends/catalog.ts: MovedCLAUDE_CODE_ENGINE_DEFINITIONto index [0],LLMIST_ENGINE_DEFINITIONto [1]Frontend & tools
web/src/components/projects/project-agent-configs.tsx: Fallback?? 'llmist'→?? 'claude-code'web/src/components/projects/projects-table.tsx: Fallback?? 'llmist'→?? 'claude-code'tools/resolve-config.ts: Fallback?? 'llmist'→?? 'claude-code'config/projects.json: Seed example default"llmist"→"claude-code"Documentation
docs/getting-started.md: Updated engine table, moved(default)annotation toclaude-codeREADME.md: Updated feature list and Key Concepts sectionCLAUDE.md: Updated Claude Code Engine section descriptionTests (13 files total)
Notes
agent_enginecolumn is nullable; NULL uses the code defaultclaude-code— requiresCLAUDE_CODE_OAUTH_TOKENschema.tsandresolution.tsCloses https://trello.com/c/69c00f6da5a200c2ecfecf1c
🕵️ claude-code · claude-sonnet-4-6 · run details