Skip to content

feat(prompts): cross-cutting prompt consistency improvements#990

Merged
zbigniewsobiecki merged 1 commit intodevfrom
feature/prompt-consistency-improvements
Mar 23, 2026
Merged

feat(prompts): cross-cutting prompt consistency improvements#990
zbigniewsobiecki merged 1 commit intodevfrom
feature/prompt-consistency-improvements

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Mar 23, 2026

Summary

  • Add VerifyChanges bridging note to Phase 4 in respond-to-ci.eta connecting manual CI commands to the VerifyChanges gadget
  • Add role hints for backlog-manager, resolve-conflicts, and respond-to-ci agent types to ACK_SYSTEM_PROMPT in ackMessageGenerator.ts
  • Add a catch-all line for custom/unknown agent types to ACK_SYSTEM_PROMPT
  • Verified partial include order (test-protocol → verification-protocol → rules-efficiency) is already consistent across all 4 code-editing templates — no changes needed

Test plan

  • Existing unit tests pass (all 332 test files, 6300 tests passing)
  • Lint passes (biome check clean)
  • TypeScript typecheck passes (zero errors)
  • respond-to-ci.eta Phase 4 now references the VerifyChanges gadget with scope=full
  • ackMessageGenerator.ts ACK_SYSTEM_PROMPT now includes entries for backlog-manager, resolve-conflicts, respond-to-ci, and a catch-all for other agent types
  • Partial include order verified as consistent (test-protocol → verification-protocol → rules-efficiency) across respond-to-review, respond-to-ci, respond-to-pr-comment, resolve-conflicts

Card: https://trello.com/c/69c127030bc8b4141ad733bf

🤖 Generated with Claude Code

🕵️ claude-code · claude-sonnet-4-6 · run details

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Small, well-scoped prompt consistency improvements. Both changes are correct and well-placed:

  1. respond-to-ci.eta: The VerifyChanges bridging note in Phase 4 is a useful cross-reference to the Verification Protocol partial included later in the template. Helps the CI-fix agent discover the gadget shortcut without requiring it to read ahead to the partials.

  2. ackMessageGenerator.ts: New role hints for backlog-manager, resolve-conflicts, and respond-to-ci align with their YAML definition roleHint values and follow the existing pattern of the other entries. The catch-all line for unknown agent types is a good addition given that custom agents can be defined dynamically.

Verified the partial include order claim (test-protocol → verification-protocol → rules-efficiency) is indeed consistent across all 4 code-editing templates. All CI checks passing.

🕵️ claude-code · claude-opus-4-6 · run details

@zbigniewsobiecki zbigniewsobiecki merged commit bc1a2c6 into dev Mar 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants