test(prompts): add PM terminology, duplicate, VerifyChanges, and debug gadget tests#991
Merged
zbigniewsobiecki merged 1 commit intodevfrom Mar 23, 2026
Merged
Conversation
nhopeatall
approved these changes
Mar 23, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Clean, well-structured test additions that guard prompt rendering correctness across four distinct concerns (PM terminology, duplicate content, VerifyChanges presence, and gadget naming). The findDuplicateBlocks helper is thoughtfully designed with good exclusions for code blocks and trivial lines. All CI checks pass.
🕵️ claude-code · claude-opus-4-6 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issuevs Trellocard, JIRA URL examples, JIRA subtask description note)respond-to-ciandrespond-to-reviewagentsListDirectory,RipGrep, andTmuxare capitalized correctlyTest plan
splittingwithpmType=jirarenders "issue" andatlassian.netURLplanningwithpmType=jirarenders "JIRA", "issue", JIRA subtask note, and atlassian URLcard,trello.com/c, "Trello")respond-to-ciandrespond-to-reviewprompts contain "VerifyChanges"debugprompt containsListDirectory,RipGrep,TmuxTrello card: https://trello.com/c/69c12720d72b1358bbe396bd
🕵️ claude-code · claude-sonnet-4-6 · run details