feat(tests): expand sharedMocks.ts with 7 new shared mock module objects#998
Merged
feat(tests): expand sharedMocks.ts with 7 new shared mock module objects#998
Conversation
nhopeatall
approved these changes
Mar 23, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Verified all 7 new mock objects against their source modules and against existing inline mocks in test files. The shapes are correct and match established usage patterns. Purely additive, all CI green.
🕵️ claude-code · claude-opus-4-6 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/helpers/sharedMocks.tsmockLogger,mockGitHubClientModule)New exports added:
mockTrelloClientModule—withTrelloCredentials,trelloClient: { getCard }(used in 8+ trigger test files)mockJiraClientModule—withJiraCredentials,jiraClient: {}(used in 6+ trigger test files)mockConfigResolverModule—isTriggerEnabled(defaulttrue),getTriggerParameters(default{}) (used in 15+ trigger files)mockAcknowledgmentsModule—postTrelloAck,deleteTrelloAck,resolveTrelloBotMemberId,postJiraAck,deleteJiraAck,resolveJiraBotAccountId(used in 6+ files)mockReactionsModule—sendAcknowledgeReaction(used alongside acknowledgments)mockSentryModule—captureException(used in 5+ files)mockLifecycleModule—setWatchdogCleanup,clearWatchdogCleanup(used in backend tests)Test plan
Trello card
https://trello.com/c/69c166a1c52a38710263866d
🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details