Skip to content

feat(tests): expand sharedMocks.ts with 7 new shared mock module objects#998

Merged
aaight merged 1 commit intodevfrom
feature/expand-shared-mocks
Mar 23, 2026
Merged

feat(tests): expand sharedMocks.ts with 7 new shared mock module objects#998
aaight merged 1 commit intodevfrom
feature/expand-shared-mocks

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Mar 23, 2026

Summary

  • Adds 7 new shared mock module exports to tests/helpers/sharedMocks.ts
  • Zero-risk, purely additive change — no existing tests modified
  • All new exports follow the established JSDoc + usage example convention from existing mocks (mockLogger, mockGitHubClientModule)

New exports added:

  • mockTrelloClientModulewithTrelloCredentials, trelloClient: { getCard } (used in 8+ trigger test files)
  • mockJiraClientModulewithJiraCredentials, jiraClient: {} (used in 6+ trigger test files)
  • mockConfigResolverModuleisTriggerEnabled (default true), getTriggerParameters (default {}) (used in 15+ trigger files)
  • mockAcknowledgmentsModulepostTrelloAck, deleteTrelloAck, resolveTrelloBotMemberId, postJiraAck, deleteJiraAck, resolveJiraBotAccountId (used in 6+ files)
  • mockReactionsModulesendAcknowledgeReaction (used alongside acknowledgments)
  • mockSentryModulecaptureException (used in 5+ files)
  • mockLifecycleModulesetWatchdogCleanup, clearWatchdogCleanup (used in backend tests)

Test plan

  • All 332 unit test files pass unchanged (6326 tests)
  • Lint passes with zero errors
  • Type checking passes with zero errors

Trello card

https://trello.com/c/69c166a1c52a38710263866d

🤖 Generated with Claude Code

🕵️ claude-code · claude-sonnet-4-6 · run details

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Verified all 7 new mock objects against their source modules and against existing inline mocks in test files. The shapes are correct and match established usage patterns. Purely additive, all CI green.

🕵️ claude-code · claude-opus-4-6 · run details

@aaight aaight merged commit 018304f into dev Mar 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants