Use a different lock to manage breakpointStore #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes VSTS 1026591 SigTerm signal in Mono.Debugging.dll!Mono.Debugging.Client.DebuggerSession::get_Breakpoints+9 `slock` is used throughout DebuggerSession, however in this case we only need to guard against multiple threads assigning an instance of BreakpointStore. Also, since BreakpointStore is thread-safe we can remove the additional locks around it where we lock on enumeration of `breakpointStore`. This fixes the case where one thread dispatches an OnExit (for example) which tries communicate with the debuggee and waits on data from the socket and another thread attempts to clean up breakpoints.
We changed the locking semantics and the dispatch will no longer wait for the current thread to release its lock when assigning the new breakpoint store
the session is created. Fix timing issue of assigning breakpoints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #267