This repository was archived by the owner on Oct 4, 2021. It is now read-only.
Fix dialog parenting issue #9470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a message dialog is shown, we try to get the currently focused top level window if no parent is provided. This is done by the GetFocusedTopLevelWindow() method that is implemented in MacPlatform. This method should not return auto-hide pads as top level windows, and there is a check for that, but the check doesn't work when the auto-hide pad is implemented with Cocoa, since the pad may have the Cocoa focus but not the GTK focus. It may happen then that an auto-hide pad is used for parenting a message dialog, and if the pad is auto-hidden, the modal dialog will also be hidden and will block the whole IDE. The patch adds an additional check to the condition for detecting if a top level is focused or not. Fixes bug #1027840
Member
Author
|
@monojenkins backport release-8.4 |
sevoku
approved these changes
Dec 13, 2019
mrward
approved these changes
Dec 13, 2019
netonjm
approved these changes
Dec 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a message dialog is shown, we try to get the currently focused
top level window if no parent is provided. This is done by the
GetFocusedTopLevelWindow() method that is implemented in MacPlatform.
This method should not return auto-hide pads as top level windows,
and there is a check for that, but the check doesn't work when
the auto-hide pad is implemented with Cocoa, since the pad may have
the Cocoa focus but not the GTK focus. It may happen then that an
auto-hide pad is used for parenting a message dialog, and if the
pad is auto-hidden, the modal dialog will also be hidden and
will block the whole IDE. The patch adds an additional check to
the condition for detecting if a top level is focused or not.
Fixes bug #1027840