Conversation
albertov19
requested changes
Jan 18, 2023
Collaborator
albertov19
left a comment
There was a problem hiding this comment.
Looks good! Left some feedback :)
Co-authored-by: albertov19 <64150856+albertov19@users.noreply.github.com>
eshaben
commented
Jan 24, 2023
Co-authored-by: albertov19 <64150856+albertov19@users.noreply.github.com>
Contributor
Author
|
Applied all of the feedback and switched around the images so that Xinxin only has to worry about removing images that are no longer needed once translations are done Had a question about one of the democracy precompile methods, so asked J0 and waiting on an answer before I'll request a review again |
Merged
3 tasks
Contributor
Author
|
Ok this is good to be reviewed again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the preimage-related docs for the RT2000 breaking changes. Reference: Moonbeam PR description and Substrate PR description
👉 Democracy Pallet Changes:
👉A new Preimage Pallet page has been added.
👉 Democracy Precompile Changes:
👉 How to Submit a Proposal Changes:
Checklist
moonbeam-docs-cnrepo, I have created a ticket for the translations in Jiramoonbeam-mkdocsto update redirectsmove-pages.pyscript to move the pages and update the image paths on the chinese repomoonbeam-docs-cncompress-images.pyscript to compress the images.moonbeam-docs-cnrepo to use the new variablesCorresponding PRs
moonbeam-foundation/moonbeam-docs-cn#211
After Translation Requirements
moonbeam-docsrepo to remove imagesmoonbeam-docsrepo to remove variablesmoonbeam-mkdocsrepo to add redirects for Chinese siteItems to be Updated
Remove all of the governance proposals images under the following directory:
images/tokens/governance/proposals/for-cn/