Add lock events to tokens pallet#3
Closed
sea212 wants to merge 3 commits intomoonbeam-foundation:masterfrom
Closed
Add lock events to tokens pallet#3sea212 wants to merge 3 commits intomoonbeam-foundation:masterfrom
sea212 wants to merge 3 commits intomoonbeam-foundation:masterfrom
Conversation
Author
|
Oopsie, wrong repository 🤦♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fundamental issue: Block indexers and processors like Subsquid have a really hard time to track locks.
This PR mirrors updates within
pallet-balances: paritytech/substrate#12287Difference in respect to paritytech/substrate#12287:
currency_idfield was added to the eventsreasonwas removed from the events (no differentiation betweenMISCandFEEreasons)The tests cases were adjusted to the previously mentioned differences:
Bonus change: Replace deprecated clippy rule name.