Open
Conversation
johnholiver
commented
Feb 17, 2026
johnholiver
commented
- centralize file processing in processEvent
- improve error handling
- enhance S3 transport settings
- add README.
- centralize file processing in processEvent - improve error handling - enhance S3 transport settings - add README.
johnholiver
force-pushed
the
joao/dgraph_backup_process_already_in_progress
branch
from
d829158 to
2fc176f
Compare
| if strings.Contains(err.Error(), "This multipart completion is already in progress") { | ||
| syn.Logger.Warn("Detected concurrent completion, verifying if object exists...") | ||
| time.Sleep(5 * time.Second) | ||
| _, statErr := syn.MinioClient.StatObject(ctx, syn.bucketName, syn.findObject(stat.Name()), minio.StatObjectOptions{}) |
Contributor
There was a problem hiding this comment.
Is that really helping? An object could exist, but its content might be corrupt. Also, we are overwriting the same object on each export, meaning this will never fail (as long as we don't reset the bucket)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.