Skip to content

WIP: Blob version 1#791

Closed
Kukoomomo wants to merge 2 commits intomainfrom
blob_v1
Closed

WIP: Blob version 1#791
Kukoomomo wants to merge 2 commits intomainfrom
blob_v1

Conversation

@Kukoomomo
Copy link
Contributor

@Kukoomomo Kukoomomo commented Oct 29, 2025

Summary by CodeRabbit

  • Chores

    • Updated multiple dependencies to newer versions, including Go modules (crypto, sync, sys, text) and cryptographic libraries for improved compatibility and security.
  • Refactor

    • Improved internal blob transaction handling with enhanced sidecar structure for better transaction composition.

@Kukoomomo Kukoomomo requested a review from a team as a code owner October 29, 2025 02:10
@Kukoomomo Kukoomomo requested review from r3aker86 and removed request for a team October 29, 2025 02:10
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 29, 2025

Warning

Rate limit exceeded

@Kukoomomo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 14 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between a838dee and 856079b.

📒 Files selected for processing (1)
  • tx-submitter/services/rollup.go (2 hunks)

Walkthrough

Updated multiple dependencies in tx-submitter/go.mod; modified BlobTxSidecar construction in rollup.go to include explicit Version field and derive BlobHashes from sidecar object instead of separate hash computation.

Changes

Cohort / File(s) Summary
Dependency Updates
tx-submitter/go.mod
Upgraded morph-l2/go-ethereum, testify (v1.9.0 → v1.10.0), and indirect dependencies including bits-and-blooms/bitset (v1.7.0 → v1.20.0), consensys/bavard (v0.1.13 → v0.1.27), consensys/gnark-crypto (v0.12.1 → v0.16.0), supranational/blst (v0.3.11 → v0.3.15); replaced crate-crypto/go-kzg-4844 with ethereum/c-kzg-4844/v2 v2.1.5; updated golang.org/x modules (crypto v0.23.0 → v0.32.0, sync v0.7.0 → v0.10.0, sys v0.20.0 → v0.29.0, text v0.15.0 → v0.21.0).
BlobTxSidecar Refactoring
tx-submitter/services/rollup.go
Restructured blob transaction composition: BlobTxSidecar now constructed with explicit Version field (BlobSidecarVersion1); BlobHashes derived from sidecar.BlobHashes() method instead of separate versioned-hash computation; Sidecar field now references fully populated sidecar object containing Version, Blobs, Commitments, and Proofs.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • The go.mod changes are routine dependency updates with predictable patterns.
  • The rollup.go changes require verification that the new BlobTxSidecar construction correctly handles versioning and that sidecar.BlobHashes() produces equivalent results to the previous inlined versioned-hash computation.
  • Review attention: Ensure the Version field assignment and sidecar method invocation align with the updated ethereum dependency API.

Possibly related PRs

Suggested labels

validator

Suggested reviewers

  • r3aker86
  • curryxbo
  • FletcherMan

Poem

🐰 Sidecars versioned, dependencies dance,
Blobs hashed with purpose, a cryptographic prance,
From separate hashes to methods so neat,
Version-aware structures make updates complete! 🎀

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "WIP: Blob version 1" is related to the changeset, specifically referring to the blob transaction versioning aspect of the changes. The main code change in rollup.go involves updating blob transaction composition to use a BlobTxSidecar with an explicit Version field set to BlobSidecarVersion1, which aligns with what the title conveys. The title is concise and avoids vague language. However, the title only partially captures the scope of changes—it emphasizes the versioning aspect but doesn't clearly indicate the broader refactoring of blob transaction handling that occurred. The "WIP" prefix is appropriate given the open PR status.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kukoomomo Kukoomomo closed this Oct 29, 2025
@Kukoomomo Kukoomomo deleted the blob_v1 branch October 29, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant