WIP: Reverts: Convert Input Validation to Revert Conditions #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisGD
reviewed
Dec 19, 2025
Comment on lines
+214
to
+216
| require shares + balanceOf(to) <= MAX_UINT256(); // To avoid overflow in the balanceOf check. | ||
| require shares <= balanceOf(from); // To avoid underflow in the balanceOf check. | ||
| require e.msg.sender != from => (shares <= allowance(from, e.msg.sender)); // To avoid underflow in the allowance check. |
Contributor
There was a problem hiding this comment.
should it be in the assert? to have a consistent style
…w happens within the loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes minimal example where Certora assigns bytes32 to a bytes4 variable.