Fix OpenClaw cron timeouts and portable memory permissions#142
Merged
Fix OpenClaw cron timeouts and portable memory permissions#142
Conversation
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Resolve test ordering conflict in jobs_test.go by keeping both the configured-timeout tests from this branch and the resolved-timezone test from master.
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two main improvements: (1) it allows the job invocation timeout to be configured via the
agents.defaults.timeoutSecondssetting, with robust validation and tests, and (2) it ensures that all files and directories in the portable memory directory have normalized, permissive permissions, also with thorough test coverage.Job invocation timeout configurability and validation:
timeoutSecondsvia theagents.defaults.timeoutSecondssetting in the resolved configuration, falling back to a default of 300 seconds if not set. The value is parsed and validated to ensure it is a positive integer, with error handling for invalid values. [1] [2] [3] [4]Portable memory permissions normalization:
PreparePortableMemoryto ensure all files are set to0666and directories to0777permissions, regardless of their previous state, by adding anormalizePortableMemoryPermissionsfunction.