claw-api: warn on principal verb skew and surface inert principals#150
Merged
claw-api: warn on principal verb skew and surface inert principals#150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances principal management and diagnostics in the Claw API by improving health endpoint reporting, adding principal normalization and version skew warnings, and expanding test coverage. It introduces mechanisms to warn users when a configured principal requires API features that may not be supported by the deployed Claw API version, and surfaces principal-related diagnostics via the
/healthendpoint.Health endpoint improvements:
/healthendpoint now returns detailed principal diagnostics, including the total principal count, a list of inert principals (those with no recognized verbs), and any normalization warnings about principal configuration.Principal store and normalization enhancements:
Storestruct now retains normalization warnings, and exposes anInertPrincipalNamesmethod to summarize inert principals. [1] [2]Principal version skew detection:
PrincipalVersionSkewWarnings, which emits warnings if principals require verbs not supported by the specified Claw API image version. This helps prevent misconfiguration when using older API images.Dependency update:
golang.org/x/mod/semverto support semantic version comparison for image tag checking.