Merged
Conversation
... to keep image size small.
mlautman
approved these changes
May 17, 2019
MikeWrock
pushed a commit
to MikeWrock/moveit2
that referenced
this pull request
Aug 15, 2022
* Adds git clone ros-planning/moveit2.git to install * removes trailing white space at ln:35 cd ~/ws_moveit2/src * removes all trailing whitespaces ln:36 * Run pre-commit Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This augments #57 to successfully build the source docker image: Sourcing the ROS underlay was missing.
Also, I cleaned up the ci docker image as originally promised my Mike in #46 (comment).
As can be seen here, the source docker image wasn't yet built.