remove deprecated ament_target_dependencies()#48
Closed
mosfet80 wants to merge 1 commit intomoveit:ros2from
Closed
remove deprecated ament_target_dependencies()#48mosfet80 wants to merge 1 commit intomoveit:ros2from
mosfet80 wants to merge 1 commit intomoveit:ros2from
Conversation
removed unnecessary and deprecated ament_target_dependencies() fix cmake 3.5 deprecation set ros2 CXX standard to CXX_17
rhaschke
requested changes
May 27, 2025
Comment on lines
4
to
7
| # Default to C++14 | ||
| if(NOT CMAKE_CXX_STANDARD) | ||
| set(CMAKE_CXX_STANDARD 14) | ||
| set(CMAKE_CXX_STANDARD 17) | ||
| endif() |
Contributor
There was a problem hiding this comment.
This should be removed completely. C++17 is the default for current compilers.
| endif() | ||
|
|
||
| find_package(ament_cmake REQUIRED) | ||
| find_package(Boost REQUIRED date_time random thread) |
| src/random_numbers.cpp | ||
| ) | ||
|
|
||
| ament_target_dependencies(${PROJECT_NAME} Boost) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed unnecessary and deprecated ament_target_dependencies()
fix cmake 3.5 deprecation
set ros2 CXX standard to CXX_17