Move product schema changes out of BMO extension #462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, this is done by Bugzilla::ModPerl. Do the same for other configurations.
…l in the "disable my account" description
mohawk2
reviewed
Mar 16, 2018
| default => 0 | ||
| }, | ||
| { | ||
| name => 'always_filleable_groups', |
There was a problem hiding this comment.
Sorry for the drive-by review, was just having a quick skim. Is filleable spelled right there? Seems like that might cause problems down the line?
Contributor
Author
There was a problem hiding this comment.
Probably should have a better name, yeah.
Contributor
Author
There was a problem hiding this comment.
Hey, @mohawk2 if you would be so kind to take a look at bugzilla/harmony#25?
Some stuff is happening in that repo because today someone submitted like 17 PRs \o/
("harmony" is "bugzilla 6 should be based on bmo" project.)
This reverts commit 5ebb025.
…ags only when present
|
This looks like it wants a rebase, as there are conflicts? Do you need further reviewing? |
Contributor
Author
|
We're doing this in the upstream repo, bugzilla/harmony#31. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.