Bug 1094306 - Add a database class for Bookmarks #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Can we enable this code? I disabled it because it did not work for some reason. But I think it will be good if we can open bookmarks in Safari.
wesj
pushed a commit
that referenced
this pull request
Nov 5, 2014
Bug 1094306 - Add a database class for Bookmarks
st3fan
pushed a commit
that referenced
this pull request
Apr 20, 2017
….Tab?).(getLastUsed #1)(JSON) -> UInt64?
st3fan
pushed a commit
that referenced
this pull request
Apr 20, 2017
….Tab?).(getLastUsed #1)(JSON) -> UInt64?
jhreis
pushed a commit
to jhreis/firefox-ios
that referenced
this pull request
Oct 23, 2017
….Tab?).(getLastUsed mozilla-mobile#1)(JSON) -> UInt64?
This was referenced Apr 6, 2020
st3fan
pushed a commit
that referenced
this pull request
Jun 10, 2021
…other applications (#8638) * Save credential identities * Fill password from database * Added UI for credential provider list * Add password list * Feature/add password manager capability (#1) * Save credential identities * Fill password from database * Added UI for credential provider list * Add password list * Extract logic to presenter Co-authored-by: Raluca Iordan <raluca.iordan@softivision.com> * Add Main interface * Added Presenter for CredentialListVC * Fixed label bug for dark mode * Added constrain for label position in welcome screen * Add dev team to fix keychain group * Uodate headers, remove commented code * Fix compile issue Co-authored-by: Raluca Iordan <raluca.iordan@softivision.com>
razvanlitianu
added a commit
that referenced
this pull request
Jun 16, 2021
…ettings (#8684) * Save credential identities * Fill password from database * Added UI for credential provider list * Add password list * Feature/add password manager capability (#1) * Save credential identities * Fill password from database * Added UI for credential provider list * Add password list * Extract logic to presenter Co-authored-by: Raluca Iordan <raluca.iordan@softivision.com> * Add Main interface * Added Presenter for CredentialListVC * Fixed label bug for dark mode * Added constrain for label position in welcome screen * Add dev team to fix keychain group * Uodate headers, remove commented code * Fix compile issue * Authenticate list with biometrics * Add passcode autentication for credential list * Fix compile issue Co-authored-by: Raluca Iordan <raluca.iordan@softivision.com>
st3fan
pushed a commit
that referenced
this pull request
Jun 17, 2021
* Save credential identities * Fill password from database * Added UI for credential provider list * Add password list * Feature/add password manager capability (#1) * Save credential identities * Fill password from database * Added UI for credential provider list * Add password list * Extract logic to presenter Co-authored-by: Raluca Iordan <raluca.iordan@softivision.com> * Add Main interface * Added Presenter for CredentialListVC * Fixed label bug for dark mode * Added constrain for label position in welcome screen * Add dev team to fix keychain group * Uodate headers, remove commented code * Fix compile issue * Formatted url in order to display host * Ordered credential list * Structured the code, fixed credential suggestions issue * Added localization for credential provider * FIxed spacing * Removed unused button * Localized strings refactoring * Added more localized strings * Added constraint for empty view in credential list screen * Fix runtime error Co-authored-by: Razvan Litianu <litianu.razvan@gmail.com> Co-authored-by: Raluca Iordan <raluca.iordan@softivision.com>
st3fan
pushed a commit
that referenced
this pull request
Jul 12, 2021
* Save credential identities * Fill password from database * Added UI for credential provider list * Add password list * Feature/add password manager capability (#1) * Save credential identities * Fill password from database * Added UI for credential provider list * Add password list * Extract logic to presenter Co-authored-by: Raluca Iordan <raluca.iordan@softivision.com> * Add Main interface * Added Presenter for CredentialListVC * Fixed label bug for dark mode * Added constrain for label position in welcome screen * Add dev team to fix keychain group * Uodate headers, remove commented code * Fix compile issue * Solves error due to duplicate code * Adds consistent design for welcome screen * Updates credential list screen design * Clean up commented code * Solves autolayout issue for empty credential list * Hides navigation bar during search for iPad * Removes spinner from welcome screen * Adds new strings format, removes localization string files * Remove unused strings files * Rename localized string to LoginsWelcomeViewTitle * Add activity indicator to Welcome screen, remove unused code Co-authored-by: Razvan Litianu <litianu.razvan@gmail.com> Co-authored-by: Raluca Iordan <raluca.iordan@softivision.com>
rilury
added a commit
that referenced
this pull request
Jul 23, 2021
* Save credential identities * Fill password from database * Added UI for credential provider list * Add password list * Feature/add password manager capability (#1) * Save credential identities * Fill password from database * Added UI for credential provider list * Add password list * Extract logic to presenter Co-authored-by: Raluca Iordan <raluca.iordan@softivision.com> * Add Main interface * Added Presenter for CredentialListVC * Fixed label bug for dark mode * Added constrain for label position in welcome screen * Add dev team to fix keychain group * Uodate headers, remove commented code * Fix compile issue * Formatted url in order to display host * Ordered credential list * Structured the code, fixed credential suggestions issue * Added localization for credential provider * FIxed spacing * Removed unused button * Localized strings refactoring * Added more localized strings * Added constraint for empty view in credential list screen * Fix runtime error * Solves error due to duplicate code * Create programmatic UI for welcome screen, remove welcome storyboard * Remove credential list storyboard and add the UI programmatically * Add small UI changes for landscape orientation * Organize colors for credential list screen Co-authored-by: Razvan Litianu <litianu.razvan@gmail.com> Co-authored-by: Raluca Iordan <raluca.iordan@softivision.com>
Closed
Closed
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
[readme] Add link to download from the App Store
6 tasks
This was referenced Jan 15, 2025
ih-codes
added a commit
that referenced
this pull request
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1094306