Refactor FXIOS-13463 #29256 [Swift 6 Migration] WebEngine @MainActor #29393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Argh. I started fixing the missing stuff in Client and ended up having to touch the |
FilippoZazzeroni
approved these changes
Sep 18, 2025
Collaborator
FilippoZazzeroni
left a comment
FilippoZazzeroni
left a comment
There was a problem hiding this comment.
LGTM @lmarceau just a nit about adding tickets.
Collaborator
|
I just approved @lmarceau I forgot it was a draft, I'll review again when you add more code. |
lmarceau
force-pushed
the
lm/FXIOS-13463-#29256-WebEngine-part-2
branch
from
805bb87 to
f73bd57
Compare
💪 Quality guardian12 tests files modified. You're a champion of test coverage! 🚀 🥇 Perfect PR sizeSmaller PRs are easier to review. Thanks for making life easy for reviewers! ✨ 🙌 Friday high-fiveThanks for pushing us across the finish line this week! 🙌 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 Client.app: Coverage: 37.35
🦊 BrowserViewController CheckWe’re tracking the size of
Generated by 🚫 Danger Swift against 430ad91 |
ih-codes
approved these changes
Sep 26, 2025
BrowserKit/Sources/WebEngine/WKWebview/Scripts/ReaderMode/DiskReaderModeCache.swift
Outdated
Show resolved
Hide resolved
BrowserKit/Sources/WebEngine/WKWebview/Scripts/ReaderMode/MemoryReaderModeCache.swift
Outdated
Show resolved
Hide resolved
ih-codes
added a commit
that referenced
this pull request
Sep 26, 2025
… from last week (#5) (#29657) * Refactor FXIOS-13511 [Swift 6] Remove Equatable from AppState and other redux states (#29495) * Remove unneeded equatable conformance on redux states * Fix tests * Fix test * Refactor FXIOS-13532 [Swift 6 Migration] Fix strict concurrency errors related to Notifications (#29514) Fun stuff * Refactor FXIOS-13502 [Swift 6 Migration] Fix main actor isolation warnings in MozillaRustComponents (#29426) "Fix" main actor isolation warnings in MozillaRustComponents with a workaround for setting accessibility identifiers to prevent larger impacts and errors in Client generated code. * Refactor FXIOS-13511 [Swift 6] Move Tab to MainActor and resolve strict concurrency warnings (#29497) * Refactor FXIOS-13511 [Swift 6] Remove Equatable from AppState and other redux states (#29495) * Remove unneeded equatable conformance on redux states * Fix tests * Fix test * Refactor FXIOS-13532 [Swift 6 Migration] Fix strict concurrency errors related to Notifications (#29514) Fun stuff * first pass of isolating tab to the main actor * Clean up tests and push commented out code * fix additional warnings * Clean up remaining warnings * fix tests * add missing ticket numbers * resolve introduced warning --------- Co-authored-by: lmarceau <lmarceau@mozilla.com> * Refactor FXIOS-13532 #29411 [Swift 6 Migration] AppDelegate + PushNotification (#29590) * Fix for Constellation update * Fix UNUserNotificationCenterDelegate methods * Fix tests * Refactor FXIOS-13235 [Swift 6 Migration] Enable strict concurrency checking in SummarizerKit (#29575) * Enable strict concurrency in SummarizerKit. * Fix closure `Sendable` warnings. * Fix some other warnings. Suppress others with FIXME tickets. * Refactor FXIOS-13463 #29256 [Swift 6 Migration] WebEngine @mainactor (#29393) * Policy decider * Make main actor * @mainactor stuff * Fix the tests * Adjust Client * Add ticket number * Adjust following comments * Refactor FXIOS-12796 [Swift 6 Migration] Fix more under-specified protocols (#29650) * Fix under-specified protocols: AddressToolbarDelegate, EmptyPrivateTabView, InsetUpdatable, PhotonActionSheetContainerCellDelegate, NavigationController. * Fix unit tests. * Refactor FXIOS-13502 [Swift 6 Migration] Fix or suppress `Sendable` and misc. warnings in MozillaRustComponents (round 1) (#29425) * Fix or suppress Sendable warnings in MozillaRustComponents. * Janky workaround for main actor isolation warning. * Update some Rust Components Sendable callbacks with @mainactor as well so the Client can reason better about main actor isolation. * Refactor FXIOS-13511 [Swift 6] Additional Strict Concurrency Clean up for Tab and Friends (#29628) * Additional tab clean up * Isolate UserScriptManager to main actor * fix tests * turn off strict concurrency * more main actor isolation * resolve introduced warnings --------- Co-authored-by: Carson Ramsden <carsonramsden@gmail.com> Co-authored-by: lmarceau <lmarceau@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
@MainActor. Examples:EngineViewand it's creationEngineSessionBackForwardListItemwhich is a protocol on top ofWKBackForwardListItemwhich is@MainActorNavigationAction,NavigationResponse,FrameInfofactoryinit method for some initializer since we cannot have default parameters to be@MainActorunder Swift 5. This will be fixed when we migrate to Swift 6, so added aTODOfor nownonisolated(unsafe)variables in some cases, created ticket to fix those if/when we pick back theWebEngineproject againcc: @ih-codes, @dataports, @Cramsden
📝 Checklist
@Mergifyio backport release/v150.0)