Add FXIOS-13387 [Trending Searches] initial recent searches cache #29485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndichin
force-pushed
the
cc/FXIOS-13498_add-initial-recent-searches-cache
branch
from
5b47985 to
5a659c5
Compare
💪 Quality guardian1 tests files modified. You're a champion of test coverage! 🚀 🧹 Tidy commitJust 4 file(s) touched. Thanks for keeping it clean and review-friendly! 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 🥇 Perfect PR sizeSmaller PRs are easier to review. Thanks for making life easy for reviewers! ✨ Client.app: Coverage: 37.32
Generated by 🚫 Danger Swift against 22c856a |
issammani
approved these changes
Sep 24, 2025
Collaborator
issammani
left a comment
issammani
left a comment
There was a problem hiding this comment.
Minor nit in comment otherwise 🔥
firefox-ios/Client/Frontend/Browser/SearchEngines/RecentSearchProvider.swift
Outdated
Show resolved
Hide resolved
Comment on lines
+77
to
+82
| for i in 1...15 { sut.addRecentSearch("search term \(i)") } | ||
|
|
||
| let result = sut.recentSearches() | ||
| XCTAssertEqual(result.count, 5) | ||
| XCTAssertEqual(result.first, "search term 15") | ||
| XCTAssertEqual(result.last, "search term 11") |
|
|
||
| var searches = recentSearches() | ||
|
|
||
| searches.removeAll { $0.caseInsensitiveCompare(trimmed) == .orderedSame } |
Collaborator
There was a problem hiding this comment.
Nice 👍 . I remember using a naive lowercase + == causing some problems in desktop in form history for turkish. caseInsensitiveCompare is the way to go.
…Provider.swift Co-authored-by: Issam Mani <issamouu69@gmail.com>
issammani
deleted the
cc/FXIOS-13498_add-initial-recent-searches-cache
branch
Merged
8 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Create a simple cache for storing recent search terms up to a max amount. The
RecentSearchProviderkeeps track of a list of search terms for each search engine.Note: We have a separate ticket to investigate using
RustPlacesinstead here. We will use this cache for now until then.🎥 Demos
Tested with different search engines and exceeding 5 search terms:
📝 Checklist
@Mergifyio backport release/v150.0)