Skip to content

Conversation

@cyndichin
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Use new method for fetching the most recent metadata instead of using an old existing one. PR where this discussion was held - #29797 (comment)

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@cyndichin cyndichin requested a review from a team as a code owner November 10, 2025 14:07
@cyndichin cyndichin requested review from issammani and mattreaganmozilla and removed request for mattreaganmozilla November 10, 2025 14:07
Copy link
Collaborator

@issammani issammani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks !!

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 39.01%

💪 Quality guardian

2 tests files modified. You're a champion of test coverage! 🚀

🧹 Tidy commit

Just 5 file(s) touched. Thanks for keeping it clean and review-friendly!

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File Coverage Required
MozillaRustComponents/Sources/MozillaRustComponentsWrapper/Places/Places.swift 0.0% 35.0%

Client.app: Coverage: 37.15

File Coverage
RecentSearchProvider.swift 89.13%

libStorage.a: Coverage: 56.45

File Coverage
RustPlaces.swift 67.53%

Generated by 🚫 Danger Swift against 793ec85

@cyndichin
Copy link
Contributor Author

Looks great. Thanks !!

thanks for adding this method 🥳 !!

@cyndichin cyndichin merged commit a1eb095 into main Nov 10, 2025
10 checks passed
@cyndichin cyndichin deleted the cc/FXIOS-13782_use-new-most-recent-method branch November 10, 2025 14:41
@github-actions
Copy link
Contributor

🚀 PR merged to main, targeting version: 145.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants