Skip to content

Refactor FXIOS-30781 [Nimbus]: Remove passing the home directory to App context in ios #30782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
issammani merged 2 commits into from
Nov 26, 2025
Merged

Refactor FXIOS-30781 [Nimbus]: Remove passing the home directory to App context in ios #30782

issammani merged 2 commits into from
Nov 26, 2025

Conversation

@yashikakhurana
Copy link
Contributor

@yashikakhurana yashikakhurana commented Nov 20, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

When first adding the date installed and date updated, we added a method to calculate those using the home directory.

However, both the Kotlin and the Swift sides of the SDK ended up passing null values for it and it isn't used anywhere. This PR removes the homeDirectory from the AppContext

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@yashikakhurana yashikakhurana requested review from a team and issammani as code owners November 20, 2025 01:54
@yashikakhurana yashikakhurana mentioned this pull request Nov 20, 2025
Merged
5 tasks
issammani
issammani requested changes Nov 20, 2025
View reviewed changes
Copy link
Collaborator

@issammani issammani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yashikakhurana. Thanks for the PR ! I left a comment about changing Generated/ files. You will need to make the change in AS first. The changes for NimbusCreate.swift are good though when we have a new AS version removing home_directory from rust 😄

MozillaRustComponents/Sources/FocusRustComponentsWrapper/Generated/nimbus.swift
public var androidSdkVersion: String?
public var debugTag: String?
public var installationDate: Int64?
public var homeDirectory: String?
Copy link
Collaborator

@issammani issammani Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't change files under Generated/ since they will be overwritten by the next AS bump. These are directly generated from uniffi. If you want this to be removed you need to remove it upstream here.

Copy link
Contributor Author

@yashikakhurana yashikakhurana Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the changes regarding the generate files, thank you for sharing that. And yes AS pr is up here mozilla/application-services#7085 🙏

MozillaRustComponents/Sources/MozillaRustComponentsWrapper/Generated/nimbus.swift
public var androidSdkVersion: String?
public var debugTag: String?
public var installationDate: Int64?
public var homeDirectory: String?
Copy link
Collaborator

@issammani issammani Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above 😄

issammani
issammani approved these changes Nov 21, 2025
View reviewed changes
Copy link
Collaborator

@issammani issammani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks. Will trigger CI once the AS bump with the change from mozilla/application-services#7085 lands here

@issammani issammani added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Nov 21, 2025
@issammani
Copy link
Collaborator

issammani commented Nov 25, 2025

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2025

rebase

✅ Branch has been successfully rebased

@issammani issammani force-pushed the remove_home_directory branch from 75dec4f to 8327e36 Compare November 25, 2025 10:43
@issammani
Copy link
Collaborator

issammani commented Nov 25, 2025

Oh the AS PR is still is open. Ignore my rebase then 🙈

@issammani issammani mentioned this pull request Nov 26, 2025
Closed
@issammani issammani force-pushed the remove_home_directory branch from 8327e36 to ee845d3 Compare November 26, 2025 10:24
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Nov 26, 2025

🌱 Tiny but mighty

Only 36 line(s) changed. Fast to review, faster to land! 🚀

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File Coverage Required
MozillaRustComponents/Package.swift 0.0% 35.0%

Generated by 🚫 Danger Swift against ee845d3

@issammani issammani removed the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Nov 26, 2025
@issammani issammani merged commit 8eeac70 into mozilla-mobile:main Nov 26, 2025
11 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

🚀 PR merged to main, targeting version: 146.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@issammani issammani issammani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yashikakhurana @issammani @mobiletest-ci-bot