Remove FXIOS-14485 [Swift 6 Migration] Clean up Common.xcconfig file

[lmarceau]

📜 Tickets

Jira ticket
Github issue

💡 Description

Remove the SWIFT_VERSION definition, as turns out in the project current state this has no effect anymore. Something probably changed since last time I had to change it.

I double-checked what version of swift we have at runtime by adding this code somewhere in the codebase (under an AppDelegate function works well since it's called early).

#if swift(>=6.2)
        print("Hello, Swift 6.2")

#elseif swift(>=6.0)
        print("Hello, Swift 6.0")

#elseif swift(>=5.10)
        print("Hello, Swift 5.10")

#endif

With those print statements, whatever the SWIFT_VERSION in Common, we always hit Hello, Swift 6.2.

📝 Checklist

• I filled in the ticket numbers and a description of my work
• I updated the PR name to follow our PR naming guidelines
• I ensured unit tests pass and wrote tests for new code
• If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
• If adding telemetry, I read the data stewardship requirements and will request a data review
• If adding or modifying strings, I read the guidelines and will request a string review from l10n
• If needed, I updated documentation and added comments to complex code

[mobiletest-ci-bot]

🧹 Tidy commit

Just 2 file(s) touched. Thanks for keeping it clean and review-friendly!

💬 Description craftsman

Great PR description! Reviewers salute you 🫡

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Generated by 🚫 Danger Swift against 634e07e

[ih-codes]

Good to know, thanks for checking this!! 💪

[github-actions]

🚀 PR merged to main, targeting version: 147.1