Bug 1519374 - Stop using gecko-focus in favor or mobile-X workers#579
Bug 1519374 - Stop using gecko-focus in favor or mobile-X workers#579JohanLorenzo merged 3 commits intomozilla-mobile:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
Submitting the task to Taskcluster failed. Detailsbad indentation of a mapping entry at line 113, column 21: |
This comment has been minimized.
This comment has been minimized.
690966b to
78f51b0
Compare
This comment has been minimized.
This comment has been minimized.
fbd38d6 to
f915af8
Compare
f915af8 to
486460d
Compare
|
I didn't do mozilla-mobile/fenix@55b419c on this repo, because you still need to clone a repo. We should change the docker image, but that can wait for mozilla-mobile/android-components#1874 to be done. |
mitchhentges
left a comment
There was a problem hiding this comment.
Big 🤔 about the refactor pattern, but approved for the underlying change
| in: | ||
| $let: | ||
| decision_worker_type: | ||
| $if: 'is_repo_trusted' |
There was a problem hiding this comment.
Having to split these onto two levels because of how Taskcluster handles variables is 😢
I made a bug for this, but it's stalled
There was a problem hiding this comment.
Yeah :/ I don't think this is a big deal for us, yet. So far, we just need 2 layers. It would become a bigger deal if we had to deal with 4, I think.
There was a problem hiding this comment.
It's unnecessary noise that you need to filter out when scanning through the file, and it throws you off: when I see a block is indented, I implicitly assume that it's a bit "different" from less-indented blocks. Though we haven't reached a "staircase" (:stuck_out_tongue:) amount of steps for $let just yet, it's still a little jarring to have to filter out that "yes this is indented, but it's just more var declarations".
There's not much we can do here, so 👍 :)
Pull Request checklist
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing featuresNot applicableBefore merging checklist