[Jan 2023 rotation] New scriptworker ed25519 key#583
Merged
hneiva merged 2 commits intomozilla-releng:mainfrom Jan 27, 2023
Merged
[Jan 2023 rotation] New scriptworker ed25519 key#583hneiva merged 2 commits intomozilla-releng:mainfrom
hneiva merged 2 commits intomozilla-releng:mainfrom
Conversation
gabrielbusta
approved these changes
Jan 26, 2023
gabrielbusta
suggested changes
Jan 26, 2023
Contributor
gabrielbusta
left a comment
gabrielbusta
left a comment
There was a problem hiding this comment.
Need to dig into those test failures
Contributor
|
Odd, the commit I made for this last time was pretty much identical: 27f58ba (other than black formatting) |
Contributor
|
How odd... |
Contributor
|
Looks like this is a Python change: Changing the method to |
Contributor
|
I filed #584 to make the CI more reproducible. |
hneiva
force-pushed
the
hneiva/scriptworker-key-rotation
branch
from
87f5ccb to
92aada2
Compare
hneiva
commented
Jan 27, 2023
| def test_create_temp_creds(): | ||
| with mock.patch.object(utils, "createTemporaryCredentials") as p: | ||
| p.return_value = {"one": b"one", "two": "two"} | ||
| with mock.patch.object(utils, "createTemporaryCredentials") as patched: |
Contributor
Author
There was a problem hiding this comment.
renamed p to patched as it conflicts with pdb p command; took me longer than I'd like to admit to realize this is why I had issues debugging it 🥲
ahal
approved these changes
Jan 27, 2023
gabrielbusta
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.