Support for .net core and .net 5#3555
Support for .net core and .net 5#3555jetelain wants to merge 1 commit intomozilla:masterfrom jetelain:master
Conversation
Upgrade obsolete SizeOf call. Add a test netcore console app (into a seperate folder to workaround nuget/msbuild mixing dependencies).
|
Thanks! Have you had a look at #3373 ? This was already an effort toward that, trying to cover CI and many platforms. |
|
No, I did not noticed a merge request was already in progress. |
Well, help would be welcome on the other PR, if you are willing ? We're preparing switching from taskcluster to github actions as well and most of the remaining work on that pr is about ci 😊 |
|
Yes, I can pickup #3373 and help with gihub actions |
Please note the goal of moving to Github Actions is making the repository easier to maintain for others than us, so feedback on anything related is highly welcome. We don't yet have the CI part in place @reuben is still working on it, but I guess you can already poke in the existing macOS bits? |
2 participants
Support for netcore and net5 with adding a build to netstandard1.3 (the lowest compatible with the code base).
Fix a warning : Upgrade obsolete SizeOf call.
Add a test netcore console app (into a seperate folder to workaround nuget/msbuild mixing dependencies).
Should fix #3285
netcore/net5 version works fine with NAudio 2.0.0 as demonstrated by console application (Could be a fix for #3540)