Skip to content

Conversation

@lougeniaC64
Copy link
Contributor

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@lougeniaC64 lougeniaC64 force-pushed the add-ios-verification-telemetry branch 2 times, most recently from d84869f to 2b010ce Compare July 15, 2025 22:39
@lougeniaC64
Copy link
Contributor Author

Hey @travis79, question for your . . . I'm trying to move the logins metrics.yaml file so that it's located in a more sensible place for android and iOS usage. However, I've made the probe-scaper angry. I'm assuming I need to update the repositories.yaml but I don't want to break the android telemetry collection currently in use.

Are there docs for this or any guidance here? Thanks!

@lougeniaC64 lougeniaC64 requested a review from skhamis July 15, 2025 22:49
@lougeniaC64 lougeniaC64 marked this pull request as ready for review July 15, 2025 22:50
@lougeniaC64 lougeniaC64 changed the title WIP: Add logins verification telemetry Add logins verification telemetry Jul 15, 2025
@lougeniaC64
Copy link
Contributor Author

@skhamis FYI you might want to wait until I get the go ahead from Travis just in case I need to change something.

@travis79
Copy link
Member

travis79 commented Jul 16, 2025

Hey @travis79, question for your . . . I'm trying to move the logins metrics.yaml file so that it's located in a more sensible place for android and iOS usage. However, I've made the probe-scaper angry. I'm assuming I need to update the repositories.yaml but I don't want to break the android telemetry collection currently in use.

Are there docs for this or any guidance here? Thanks!

I'm not sure about docs, but you should only need to update the repositories.yaml file in probe_scraper to point to the new path, and see that it lands on the same day as your moving a metrics.yaml/pings.yaml patch would to avoid making it "angry" 😅.

Do you have a PR to update probe_scraper or is there some other way I can help with this? I'd be more than happy to lend my assistance in whatever way you need me to.

@lougeniaC64
Copy link
Contributor Author

Do you have a PR to update probe_scraper or is there some other way I can help with this? I'd be more than happy to lend my assistance in whatever way you need me to.

No no, I just wanted to make sure I went about this the right way. I'll create a probe_scraper PR--thanks!

Copy link
Contributor

@skhamis skhamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the late review on this one, LGTM!

@lougeniaC64 lougeniaC64 force-pushed the add-ios-verification-telemetry branch from 2b010ce to 277c4c2 Compare July 24, 2025 18:50
@lougeniaC64 lougeniaC64 added this pull request to the merge queue Jul 25, 2025
Merged via the queue into main with commit 82d161b Jul 25, 2025
14 of 15 checks passed
@lougeniaC64 lougeniaC64 deleted the add-ios-verification-telemetry branch July 25, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants