This repository was archived by the owner on Feb 21, 2018. It is now read-only.
Merged
Conversation
Initial pass through methods.
First pass at systems methods.
Shifting method detail into separate pages.
Contributor
|
Hey @SueSmith looks good to me...re: models, I think what you did so far is fine. Like you said, might make more sense as a tutorial down the line.
We're not using them for cities of learning, so they're back burnered. We'd like to use them long term, so please log the errors you found as issues against badgekit-api.
Just a heads up, I'm adding evidence into the badgekit-api this week. |
Contributor
|
Also, I see why the tests are failing. I'll take care of that after we merge this. |
Contributor
Author
|
Thanks @cmcavoy - will create those claim code issues and keep an eye out for evidence stuff. |
This was referenced Jun 23, 2014
Contributor
Author
|
Added the claim code issues - some on API, some on client (where relevant API endpoints seem ok). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First go at completing/ updating the client docs. Few questions/ notes etc:
/docs..?claimClaimCodedidn't work for me - theclaimedfield seems to update in the db but my app hangs and submitted emails don't get added to theemailfield. (I've commented out references to the method for the moment. Also didn't include methodclaimin models for the same reason.)updateClaimCodegave me[MethodNotAllowedError: PUT is not allowed]- commented out.generateRandomClaimCodegave me[NotAuthorizedError: Missing JWT claim: body]- commented out.getClaimCodeswithoutbadgegives[ResourceNotFoundError: /systems/badgekit/codes does not exist]- should it be[ContextError: Context not of required type: Badge]?updateBadgeInstanceI get[MethodNotAllowedError: PUT is not allowed]- commented out for now.deleteReviewthe client seems to return null rather than the deleted review.. - haven't included the response in the docs for now.evidencemethods since I think these were removed from the API..Give me a shout if anything isn't clear.. Feedback appreciated! 🙉